fix: PromisePoolCluster.of returns PromisePoolCluster instead of PoolNamespace

[jcmartineztiempo]

Fixes #3091.

[codecov]

Codecov Report

Attention: Patch coverage is 95.68966% with 20 lines in your changes missing coverage. Please review.

Project coverage is 88.97%. Comparing base (605fa04) to head (1f5d034).
Report is 83 commits behind head on master.

Files with missing lines	Patch %	Lines
lib/parsers/static_binary_parser.js	95.73%	9 Missing ⚠️
promise.js	82.00%	9 Missing ⚠️
lib/commands/query.js	95.23%	1 Missing ⚠️
lib/connection_config.js	94.73%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #3261      +/-   ##
==========================================
+ Coverage   88.45%   88.97%   +0.52%     
==========================================
  Files          83       85       +2     
  Lines       13067    13497     +430     
  Branches     1393     1559     +166     
==========================================
+ Hits        11558    12009     +451     
+ Misses       1509     1488      -21     

Flag	Coverage Δ
compression-0	88.97% <95.68%> (+0.52%)	⬆️
compression-1	88.97% <95.68%> (+0.52%)	⬆️
static-parser-0	86.54% <25.00%> (?)
static-parser-1	87.36% <95.47%> (?)
tls-0	88.39% <95.68%> (+0.54%)	⬆️
tls-1	88.74% <95.68%> (+0.53%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[jcmartineztiempo]

Test added.

[wellwelwel]

Hey @jcmartineztiempo, thanks!
I couldn't pause to understand why the last test wouldn't finish, but it seems to have been fixed in recent commits.

Also, sorry for the lack of infos or support, December is usually very hectic 😅

[jcmartineztiempo]

Hi @wellwelwel,

Yeah...the last test wouldn't finish due a sql syntax error in mysql 5.7. I'll look into it later.

Don't worry about support...it's my first ever pool request!!

[wellwelwel]

Hi, @jcmartineztiempo, bringing this #3091 (comment) here:

Hi, when will it be merged and released?

Because of this, I figured that the work was not yet complete:

Yeah...the last test wouldn't finish due a sql syntax error in mysql 5.7. I'll look into it later.

Sorry for the miscommunication.

Could you rebase just to trigger the recent tests into your changes?

---

@sidorares, just a friendly ping: could you enable the following option in the repository settings?

• This will display a button that allows us to automatically rebase outdated branches without conflict and ensure that the test suite always runs through the latest version.

[jcmartineztiempo]

Hi,

just enabled.

Thanks

[wellwelwel]

Hi,

just enabled.

Thanks

Hey @jcmartineztiempo, this point is for @sidorares in MySQL2 repository 🙋🏻‍♂️