fix: gracefully close pool connections

[dstankovd]

Fixes #3148

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.30%. Comparing base (cdc9415) to head (acd8b70).

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #3180      +/-   ##
==========================================
+ Coverage   88.23%   88.30%   +0.06%     
==========================================
  Files          83       83              
  Lines       12985    12975      -10     
  Branches     1373     1373              
==========================================
  Hits        11457    11457              
+ Misses       1528     1518      -10     

Flag	Coverage Δ
compression-0	88.30% <100.00%> (+0.06%)	⬆️
compression-1	88.30% <100.00%> (+0.06%)	⬆️
tls-0	87.69% <100.00%> (+0.06%)	⬆️
tls-1	88.06% <100.00%> (+0.06%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[wellwelwel]

Thanks, @dstankovd 🙋🏻‍♂️

Do you think a test can be added to cover these changes?

[dstankovd]

Thanks, @dstankovd 🙋🏻‍♂️

Do you think a test can be added to cover these changes?

Hey, I've added a new test covering theses changes :)

[wellwelwel]

@dstankovd, in #3081 we moved the lib/pool.js and lib/pool_connection.js to lib/base/pool.js and lib/base/pool_connection.js. This led to the need for a rebase.

Sorry for the inconvenience 🙋🏻‍♂️

Also, thanks for the tests 🤝

[dstankovd]

Hey @wellwelwel. I've rebased the branch, not sure why there are failed checks tho..

[wellwelwel]

@dstankovd, I don't know if it's a bug or if it's intentional, but it seems that Deno has completely removed support for local CommonJS in the canary version.

In any case, the failed workflows are unrelated to your changes 🙋🏻‍♂️

---

Edit: Not a bug, but a breaking change (already fixed in #3209).

[wellwelwel]

I've rebased the branch, not sure why there are failed checks tho..

@sidorares, could you enable the following option in the repository settings?

• This will display a button that allows us to automatically rebase outdated branches without conflict.

[dstankovd]

Hey @wellwelwel ,

rebased again, so all checks should pass now :)