Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: constants, parserCache, Pool and Pool Cluster typings #2084

Merged
merged 18 commits into from
Jun 24, 2023

Conversation

wellwelwel
Copy link
Collaborator

@wellwelwel wellwelwel commented Jun 24, 2023

It's expected that this PR will solve:

Naturally, addressing all remaining known type-related issues related to version ^3.x 🤹🏻‍♀️


Constants

Reviewed ✔️

  • JS (required to fix the types)
    • Add missing constants to promise.js:
      • Types
      • Charsets
      • CharsetToEncoding
  • TS
    • Create typings and tests for:
      • Types
      • Charsets
      • CharsetToEncoding

Parsers

Reviewed ✔️

  • JS (required to fix the types)
    • Add missing parserCache methods to promise.js:
      • setMaxParserCache
      • clearParserCache
  • TS
    • Create typings and tests for:
      • setMaxParserCache
      • clearParserCache

Pool

Reviewed ✔️

  • TS
    • Add URI overload and testing to createPool

Pool Cluster

Fix mysql2 first, then create mysql2/promise typings ✔️
Reviewed ✔️

  • TS
    • Add missing Connection URI overload, like poolCluster.add('conn', 'uri')
    • Add missing config option uri in add method
    • end, of and add methods can't be in a PoolCluster connection
    • of type can't be a PoolCluster
    • Create Pool Cluster typings for promise.d.ts
    • Create tests

@wellwelwel wellwelwel merged commit c973c1c into sidorares:master Jun 24, 2023
@wellwelwel wellwelwel deleted the fix-types-1 branch June 30, 2023 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant