-
-
Notifications
You must be signed in to change notification settings - Fork 632
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: resolve small eslint rules and TS settings #2073
Conversation
@sidorares, is it okay if I merge the refactoring up to the point where no types are actually changed? Then I would stop at the main change, which would be the joining the spread types and wait for an accurate review.
|
go for it @wellwelwel |
@sidorares, it's done. So far, no type has changed 🤹🏻♀️ Now, I will create a separate PR for the last two refactoring tasks:
|
About 1,209 additions and 1,791 deletions:
package-lock.json
by removing unused dependenciesindentation: 2
from ESLint andprintWith: 80
from PrettierIn this refacoring task:
eslint
rules:@types/mocha
,@types/chai
,mocha
andchai
dependenciestsconfig.json
index.d.ts
,promise.d.ts
and thetypings
folder"strictFunctionTypes": false
An easy way to review it, is looking for
commits
:And finally:
indentation
andprintWidth
👻