Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support to decode the FUT092 remote #846

Merged
merged 2 commits into from
Nov 23, 2024
Merged

Conversation

Jojo-1000
Copy link

It uses the same protocol as FUT089, but has separate commands for color temperature and saturation.

Closes #844

Please review my naming changes (I used FUT092 in the same enum as FUT089 options, not sure if that is appropriate).

I chose not to change the updateTemperature and updateSaturation methods, because that would require testing on a RGB light. However, it should be possible to use the new commands to avoid the current mode-dependent behavior.

It uses the same protocol as FUT089, but has separate commands for color temperature and saturation.

Closes sidoh#844
@sidoh
Copy link
Owner

sidoh commented Nov 15, 2024

Oh nice, there are just separate commands. I thought the conflict was going to be worse than that.

It feels slightly bad to couple the remote types so tightly, but I suppose that's unavoidable. One extra weirdness here is FUT089 supports 8 groups, but it looks like FUT092 only supports 4? Not clear how that would cause problems, though.

I'm guessing we're punting on adding FUT092 as a selectable remote type for transmitting?

I think I can probably test changes to updateTemperature and updateSaturation with my bulbs, although they're quite old and it's possible they don't work. If you wanna make the change I can test out.

@Jojo-1000
Copy link
Author

It feels slightly bad to couple the remote types so tightly, but I suppose that's unavoidable. One extra weirdness here is FUT089 supports 8 groups, but it looks like FUT092 only supports 4? Not clear how that would cause problems, though.

I guess you could think of it like having a common protocol, but both remotes only produce a subset (FUT089 only has the mixed saturation, FUT092 only has 4 groups). That is probably because the buttons get too tiny on the remote, or maybe their controller can only support so many.

For transmitting our own data I hope that since the protocol id is the same, all lights should support both equally.

@Jojo-1000
Copy link
Author

@sidoh I made the change. Now my light no longer changes color temperature when playing with the color select, so that is consistent with the remote.

What you need to verify is whether the saturation command also forces the RGB mode or not. Currently in the state the mode stays color_temp.

@sidoh
Copy link
Owner

sidoh commented Nov 23, 2024

Was able to confirm this works with my fut089-compatible bulbs!

@sidoh sidoh changed the base branch from master to 1.13.1 November 23, 2024 21:30
@sidoh sidoh merged commit 18f437e into sidoh:1.13.1 Nov 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remote fut092 recognized as fut089
2 participants