Don't activate every longpress nightmode #718
Open
+23
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jojo-1000
reviewed
Nov 15, 2024
| } else if (arg >= 9 && arg <= 17) { | ||
| result[GroupStateFieldNames::STATE] = "OFF"; | ||
| bulbId.groupId = arg-9; | ||
| result[GroupStateFieldNames::LONG_PRESS] = long_press; | ||
| if (long_press) { | ||
| result[GroupStateFieldNames::STATE] = "ON"; |
There was a problem hiding this comment.
This changes the behavior of the packet sniffer. Now when I keep pressing the off button, it will show one "OFF" state and then "ON" with night_mode. Before it was continuous "OFF" with night mode. I am not sure which way is better, but to me it is confusing that I am pressing off but the command shows as on.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially covers #714 .
It will send only night mode on long OFF button press.
It will send on the update channel "long_press" with true/false when it's possible to do it (ON, OFF, S-, M, S+, W).