Login stays on Connecting

[ManuNovas]

🤷🏽‍♂️ Current Behaviour

When I'm trying to connect my google Account, it stays on green "Connecting" window.

🎯 Expected Behaviour

I saw that this issue fixed on Ubuntu 18.x but appear again on Ubuntu 19.04

👟 Steps to Reproduce (S2R)

1. Click on SingUp with Google:
   
2. It appear login form from google but shortly:
   
3. After that, appear the green window
   

🏡 Environmental Context

App Version
v9.0.9
Installation Type
Setup: Default with rpm package
Operating System
Ubuntu 19.04

[btaens]

The issue seems to stem from the app attaching a 'did-fail-load' event listener to the WebView that is responsible for the Google OAuth login.

If you check, you can see the issue is not present when you login through Facebook.

Google on the other hand, seems to call a CheckConnection endpoint that it immediately cancels (not sure why, must be some authentication thing), which the pb-for-desktop event handler catches, even though it's a -3 user aborted event, and sends the offline IPC message, which in turn triggers the spinner animation.

Relevant code is at:

pb-for-desktop/app/scripts/renderer/main.js

Lines 196 to 203 in 6f076b4

	/**
	* @listens webviewViewElement#Event:did-fail-load
	*/
	webviewViewElement.addEventListener('did-fail-load', () => {
	logger.debug('webviewViewElement#did-fail-load')
	onOffline()
	})

[AskAlice]

@btaens can you build and release? This really breaks for me. Also doesn't work on facebook
edit: a fix I found is, hitting ctrl+shift+I then deleting the spinner element

[ManuNovas]

Thank You, Last update allow me login on google.

[sidneys]

@ManuNovas The newest release addressed this issue and was just deployed - looking forward to your feedback: https://github.com/sidneys/pb-for-desktop/releases

[sidneys]

@ManuNovas @btaens @AskAlice

The application was just deployed in version 10.2.0, and the issue could not be reproduced on either macOS or Ubuntu, thus this issue will be closed. If it should however persist or reoccur, please add your feedback.

Kind regards, S

[jhg03a]

This appears to have come back with v11.0.2 on an m2 mac.

[TechnoSwiss]

Also present again with v11.0.2 on Win10, getting around it with developer mode and deleting the spinner element.

[SC7639]

Also, present again for me on mac os v11.0.2