Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not getting any pushes on my Mac desktop anymore #100

Closed
shoguevara opened this issue Feb 28, 2019 · 23 comments
Closed

Not getting any pushes on my Mac desktop anymore #100

shoguevara opened this issue Feb 28, 2019 · 23 comments

Comments

@shoguevara
Copy link

shoguevara commented Feb 28, 2019

I have pushbullet app on my phone and sidneys pb-for-dekstop on my Mac and my Ubuntu desktop.
For some reason I no longer receiving any notifications on my MacBook installation. Tried resetting the app configuration, reinstalling from scratch, muting/unmuting.
Unfortunately nothing works.
Embedded test notification works fine, so it's not the notification permission problem. But I don't get any synced notifications from my phone and the ones I intentionally send from my phone to the Mac.
Could anyone pls advise where else to look to dig deeper?
App Version
v8.9.5
Installation Type
Setup
Operating System
Mac OS Mojave 10.14.3

@shoguevara
Copy link
Author

shoguevara commented Mar 4, 2019

Upgraded to 8.10.1 - the issue is still there.
I also can confirm, that I can send notifications from pb-for-dekstop to mobile client, SMS mirroring also works. Just not getting notifications on Mac desktop.
I also can confirm, that pushes work fine for chrome app on my Mac too, but it's not the option to use it! I love pb-for-dekstop!

@shoguevara
Copy link
Author

I also just received notification from connected IFTT service on my Mac...

@mihovilm
Copy link

mihovilm commented Mar 4, 2019

Same

@ldodge94
Copy link

I'm also dealing with this same issue. I'm on version 8.12 and I've repeatedly resent configuration and reconnected to my android phone by no dice. Running Mojave.

@fernandex00
Copy link

Same here on Ubuntu 18.10

@SorrowfulMercies
Copy link

Not getting notifications on Windows 10 either

sidneys added a commit that referenced this issue May 20, 2019
sidneys added a commit that referenced this issue May 20, 2019
@noranyan
Copy link

The issue still exists.

I can send pushes from Mac to other devices (Android, iOS, Windows) but Mac can't receive any.

Have tried reconnecting to PushBullet, reset configuration and reinstall but to no avail.

@fernandex00
Copy link

Same here Ubuntu 19.04

@danperks
Copy link

danperks commented Jul 1, 2019

Same issue on ElementryOS

@btaens
Copy link
Contributor

btaens commented Jul 7, 2019

Same on Pop OS 19.04

@btaens
Copy link
Contributor

btaens commented Jul 23, 2019

Still seems to be an issue in v9.0.9.

@btaens
Copy link
Contributor

btaens commented Jul 24, 2019

All right, so the issue seems to come from generateNotificationImage() method of push.js.
The method seems to be trying to generate an icon for the notification from various image sources (chat url, sender account image, etc..) and returns whichever gives back a valid image first in a fallback sequence.

However, when it's trying to generate the chat icon, it looks for the open chat room by email with window.pb.targets.by_email(). This returns a null object, as a chat room by this email doesn't exist.
It then tries to get the image_url property of our null object, which then throws an error, stopping the notification from showing all together.

Relevant code:

if (!!push.sender_email) {
const target = window.pb.targets.by_email(push.sender_email)
iconChat = target.image_url
}

@charles-001
Copy link

charles-001 commented Aug 15, 2019

@btaens,

Thanks for the commit! Unfortunately though, it didn't fix the issue for me. I changed the code to use your commit and re-built it for MacOS, but... it wasn't the magic bullet :( Text messages are still not popping up.

@GodLesZ
Copy link

GodLesZ commented Sep 2, 2019

Not only MacOS related (please change issue title and labels)
Also don't getting any notifications on my ARCH Linux (Manjaro)

@GodLesZ
Copy link

GodLesZ commented Sep 2, 2019

Update: The fix from @btaens help's me on ARCH Linux. Using the Android app and typing something in "push", either directed to all or just my PC, will create a notification on linux.

But using the test notification button in the Android app doesn't create a notification on linux.
Instead I'm receiving a notification on android.
Also, notifications from Android app's doesn't create a notification on the PC either.
So the fix currently only fixes a potential access on null.

Debugging the push.js turns out that testIfPushIsIgnored is returning true, because the push object doesn't contains a active property.

if (!!!push.active) {
return true
}


Either the android app creates an invalid structure, or the electron app handles the test notification not properly.
Maybe @sidneys can help identifying the problem?

Some self-crafted notification, which works with #107

{
  "active": true,
  "iden": "xxx",
  "created": 1567401289.72517,
  "modified": 1567401289.758848,
  "type": "note",
  "dismissed": false,
  "guid": "5c61133c-af06-4a78-ab55-ad1008fa47b4",
  "direction": "self",
  "sender_iden": "xxx",
  "sender_email": "xxx",
  "sender_email_normalized": "xxx",
  "sender_name": "GodLesZ Blubb",
  "receiver_iden": "xxx",
  "receiver_email": "xxx",
  "receiver_email_normalized": "xxx",
  "source_device_iden": "xxx",
  "awake_app_guids": [
    "xxx"
  ],
  "body": "Test an alle"
}

And here a test notification using the Android app "test" button in the "mirror" tab, which triggers isIgnored

{
  "actions": [
    {
      "label": "Fertig",
      "trigger_key": "com.pushbullet.android_3_null_Fertig"
    }
  ],
  "application_name": "Pushbullet",
  "body": "Wenn Sie dies an Ihrem PC sehen, funktioniert die Benachrichtigungsweiterleitung!",
  "client_version": 349,
  "dismissible": true,
  "icon": "some valid base64 hash",
  "notification_id": "3",
  "package_name": "com.pushbullet.android",
  "source_device_iden": "xxx",
  "source_user_iden": "xxx",
  "title": "Testbenachrichtigung",
  "type": "mirror"
}

Aaaand during writing this answer, here his again a notification from an Android game app, which triggers isIgnored with true and is therefore not shown on my linux:

{
  "application_name": "Jurassic Tribes",
  "body": "Eine Sammeltruppe ist ist zurückgekehrt",
  "client_version": 349,
  "dismissible": true,
  "icon": "some valid base64 hash",
  "notification_id": "-261202488",
  "package_name": "com.games37.jc",
  "source_device_iden": "xxx",
  "source_user_iden": "xxx",
  "title": "Jurassic Tribes",
  "type": "mirror"
}

Lastly, if I try hard commenting out the active check, all notifications are directed correctly.

if (!!!push.active) {
return true
}

But I still don't have any clue about the side effects of this change.

@charles-001
Copy link

I'm not sure this project is still supported by the developer... my issue has been created for 23 days and no response yet.

@GodLesZ
Copy link

GodLesZ commented Sep 2, 2019

I'm not sure this project is still supported by the developer... my issue has been created for 23 days and no response yet.

Yea but he released 9.5.0 just 24 days ago, so it's still active.

@charles-001
Copy link

Yeah, true. I guess I see this as a fundamental bug w/ the project because of the fact that receiving notifications on PC is the main purpose to use it and I've received 0 support in the past month. I know I'm not paying for it and I'm not owed anything, but I'd think this would be a top priority to fix for usability.

@gregdotca
Copy link

I'm unable to receive notifications on Linux Mint 19.2, and it sounds like it may be related to this issue.

  • My IFTTT applets push notifications to me just fine
  • Notifications aren't being mirrored (including SMS notifications)
  • I don't receive pushes that I send from my phone
  • Universal copy/paste works fine

sidneys added a commit that referenced this issue Nov 14, 2019
fix(push): fixes push notifications not showing (#100)
@sidneys
Copy link
Owner

sidneys commented Nov 14, 2019

@vuther
@GodLesZ
@shoguevara

Thanks for all your efforts, comments and documentation. The issue will be addressed asap, there was simply a lack of time. A new version of the project will be released today.

@sidneys
Copy link
Owner

sidneys commented Nov 14, 2019

@vuther
@GodLesZ
@shoguevara

Thanks for all your efforts, comments and documentation. Due to a lack of time, work on the issue backlog had been delayed for some time.

The issue was addressed in the new release (with great help via @btaens pull requests) and is available here:
https://github.com/sidneys/pb-for-desktop/releases

Please validate whether the bug still occurs.

Cheers,
S

@sidneys
Copy link
Owner

sidneys commented Nov 26, 2019

I'm unable to receive notifications on Linux Mint 19.2, and it sounds like it may be related to this issue.

* My IFTTT applets push notifications to me just fine

* Notifications aren't being mirrored (including SMS notifications)

* I don't receive pushes that I send from my phone

* Universal copy/paste works fine

@chetcuti

Thanks for the report. Does the issue still persist in version 10.2.0?

Kind Regards, S

@gregdotca
Copy link

@sidneys, I just installed the most recent version and it seems to have fixed the issues I was having. Notifications are now mirroring and I'm receiving pushes on my desktop that I sent from my phone.

Unfortunately I've actually had to switch away from PB for Desktop though. Since the notifications aren't persistent I've had to switch to the browse extension, which does have persistent notifications. I would prefer to use the actual app but I was missing too many notifications because I rarely look down at my taskbar to see if there are new notifications.

@sidneys sidneys closed this as completed Aug 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests