Onboard new GNO-A collateral

[valiafetisov]

Preparation for the GNO onboarding

• Quick fix to enable creation of an auction on goerli
• Add GNO-A collateral config
• Wait for the spell to lend into the chainlog (on goerli)
  • Or compile and execute in the fork
• Test participation with DAI

[valiafetisov]

As there are GNO contracts now on the goerli, I think it should be ready to test from our side

[valiafetisov]

Functional testing scenario:

• Set REMOTE_RPC_URL inside core/.env to alchemy endpoint on goerli
• Set RPC_URL inside frontend/.env to http://127.0.0.1:8545
• Start Create collateral auction simulation inside core via npm run simulate
• Start frontend via npm run dev

Results:

• I was able to create GNO-A vault using simulation ✔️

  

• I was able to fetch created vault in our UI ✔️

  

• I was able to liquidate vault using simulation ✔️

• I was able to view auction in the UI ✔️

  

• I was able to participate in auction with DAI and get GNO token in return into my wallet ✔️

  

But encountered a state of the UI which seems to be a bug: after successful bidding, bid with dai transaction page currently stays active and still suggests you to participate as if the auction was not finished. I guess this is unrelated to the GNO and can be addressed in other PR.

[valiafetisov]

• After testing, the outstanding part in this PR is the hardcoded CDP_REGISTRY address (missing from the chainlog) that should be either removed or refactored in a way that doesn't break other networks. This is not trivial, so I would remove it here and create issue to come up with strategy how we deal with contracts missing from chainlog
• Also we would need to remove GNO from tests: since there are no contracts from the mainnet the tests will always fail

But what is the next course of actions regarding the onboarding? Do we still want to test the mainnet spell?

[LukSteib]

Was able to replicate all of the steps that you described above successfully ✔️

But encountered a state of the UI which seems to be a bug: after successful bidding, bid with dai transaction page currently stays active and still suggests you to participate as if the auction was not finished.

Agree, experienced the same problem. Will create an issue for it.

But what is the next course of actions regarding the onboarding? Do we still want to test the mainnet spell?

Yes, I'd still like to run the test based on mainnet spell. There we should also be able to properly test Callee.

[valiafetisov]

Currently not able to execute mainnet spell (makerdao/spells-mainnet#295, commit 9d9215d), casting fails with ds-pause-delegatecall-error.

[valiafetisov]

Currently, the same ds-pause-delegatecall-error is thrown during execution of the deployed mainnet spell (the address and the block is recovered from this commit: makerdao/spells-mainnet@82f9e9b). Not sure what's going on here.

Reproduction steps:

1. Clone our repo
2. Create required env var (more specifically, REMOTE_RPC_URL inside core/.env that will be used for forking)
3. Start simulation environment cd core && npm ci && npm run simulate
4. Choose Onboard new collateral, then GNO-A onboarding via prompts
5. See that the transaction fails inside hardhat fork with reverted with reason string 'ds-pause-delegatecall-error'

Note that current simulation forks at 16145121 (right after the spell was deployed), but I've also tried warping and casting scheduled spell on the latest block with the same outcome. I've also created calculateCastTimestamp function based on the MCD_PAUSE.delay() and the "working hours" logic, but that doesn't seem to be the problem either.

[LukSteib]

Since the spell was casted to mainnet, can we add GNO-A to our set of collaterals for the "Create collateral auction" simulation.
This will enable us to properly test functionality.

[valiafetisov]

Removed GNO-A from blacklist and was able to create a participate in the auction 🙂

ℹ collateral keeper: auction "GNO-A:1" net profit is 87817 DAI after transaction fees, moving on to the execution                                                                                 18:30:33
ℹ keeper: wallet "0xf39Fd6e51aad88F6F4ce6aB8827279cffFb92266" has not been authorized yet. Attempting authorization now...                                                                        18:30:33
ℹ Transaction is preparing to be mined...                                                                                                                                                         18:30:33
ℹ Transaction is pending to be mined...                                                                                                                                                           18:30:33
ℹ Transaction was mined into block "17218243"                                                                                                                                                     18:30:33
ℹ keeper: wallet "0xf39Fd6e51aad88F6F4ce6aB8827279cffFb92266" successfully authorized via "0x8b2f4b3c97b8714f85574231649bae9fb0d0a674654a26a5e2182006d4abb8ca" transaction                        18:30:33
ℹ collateral keeper: auction "GNO-A:1" net profit is 87817 DAI after transaction fees, moving on to the execution                                                                                 18:30:33
ℹ keeper: wallet "0xf39Fd6e51aad88F6F4ce6aB8827279cffFb92266" has already been authorized                                                                                                         18:30:33
ℹ keeper: collateral "GNO-A" has not been authorized on wallet "0xf39Fd6e51aad88F6F4ce6aB8827279cffFb92266" yet. Attempting authorization now...                                                  18:30:33
ℹ Transaction is preparing to be mined...                                                                                                                                                         18:30:33
ℹ Transaction is pending to be mined...                                                                                                                                                           18:30:33
ℹ Transaction was mined into block "17218244"                                                                                                                                                     18:30:33
ℹ keeper: collateral "GNO-A" successfully authorized on wallet "0xf39Fd6e51aad88F6F4ce6aB8827279cffFb92266" via "0x37fa2127e688aeab9fce8386d49b98c31e26a4b91845adc17c492a9a7454aed4" transaction  18:30:33
ℹ collateral keeper: auction "GNO-A:1" net profit is 87817 DAI after transaction fees, moving on to the execution                                                                                 18:30:33
ℹ keeper: wallet "0xf39Fd6e51aad88F6F4ce6aB8827279cffFb92266" has already been authorized                                                                                                         18:30:33
ℹ keeper: collateral "GNO-A" has already been authorized on wallet "0xf39Fd6e51aad88F6F4ce6aB8827279cffFb92266"                                                                                   18:30:33
ℹ collateral keeper: auction "GNO-A:1": attempting swap execution                                                                                                                                 18:30:33
ℹ Transaction is preparing to be mined...                                                                                                                                                         18:30:33
ℹ Transaction is pending to be mined...                                                                                                                                                           18:30:37
ℹ Transaction was mined into block "17218245"                                                                                                                                                     18:30:38
ℹ collateral keeper: auction "GNO-A:1" was succesfully executed via "0xa0d003a41bbb3f7871c3d349d449ea51ca894ccd220619ed12170dc2d95854f4" transaction  

[LukSteib]

Agree

Was able to simulate GNO-A auction based on hardhat mainnet fork and participate in the auction via UI using unsiwap v3 callee

[KirillDogadin-std]

removed the connection of the blacklist with simulations, added the collateral to the blacklist