Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Copy and integrate MarketPriceSelection #520

Closed
wants to merge 1 commit into from
Closed

Copy and integrate MarketPriceSelection #520

wants to merge 1 commit into from

Conversation

aomafarag
Copy link
Contributor

Closes #496.

Checklist:

  • issue number linked above after pound (#)
    • replace "Closes " with "Contributes to" or other if this PR does not close the issue
  • issue checkboxes are all addressed
  • manually checked my feature / not applicable
  • wrote tests / not applicable
  • attached screenshots / not applicable

LukSteib
LukSteib requested changes Nov 4, 2022
View reviewed changes
Copy link
Contributor

@LukSteib LukSteib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Current selection is not reflected in the table
  • Switching (ie. selecting another callee) does not work
  • The routes are not displayed properly (in example below I would expect to see ETH -> DAI)

image

@aomafarag aomafarag closed this Nov 5, 2022
@aomafarag aomafarag deleted the select-market-price branch November 5, 2022 00:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LukSteib LukSteib LukSteib requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create MarketPriceSelection component
2 participants
@aomafarag @LukSteib