-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improved number formatting #481
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frontend/components/panels/VaultLiquidationLimitsCheckPanel.vue
Outdated
Show resolved
Hide resolved
16 tasks
zoey-kaiser
commented
Oct 17, 2022
zoey-kaiser
commented
Oct 17, 2022
frontend/components/common/formatters/AnimatedNumber.stories.js
Outdated
Show resolved
Hide resolved
frontend/components/panels/VaultLiquidationLimitsCheckPanel.vue
Outdated
Show resolved
Hide resolved
10 tasks
valiafetisov
approved these changes
Oct 31, 2022
LukSteib
approved these changes
Nov 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #474
I decided to use a custom regex expression over native JavaScript number functions, because the native functions only support the number type. As we do a lot of other custom formatting, the end result is always a string, resulting in them being useless. In addition to this formatting the number before we add our automatic decimal place messes up the end results, so I thought it was easier to apply the thousand commas last with regex rather then before. It also helps with the fact that we use numbers, BigNumbers and strings in some places, allowing me to simplify the amount of types the function needs to support.
Checklist:
#
)