Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added VaultsTable and stories #456

Merged
merged 12 commits into from
Sep 20, 2022
Merged

Added VaultsTable and stories #456

merged 12 commits into from
Sep 20, 2022

Conversation

zoey-kaiser
Copy link
Contributor

@zoey-kaiser zoey-kaiser commented Sep 9, 2022 •
edited
Loading

Closes #434

Screenshot 2022-09-12 at 16 10 20

Checklist:

  • issue number linked above after pound (#)
    • replace "Closes " with "Contributes to" or other if this PR does not close the issue
  • issue checkboxes are all addressed
  • manually checked my feature / not applicable
  • wrote tests / not applicable
  • attached screenshots / not applicable

@zoey-kaiser zoey-kaiser marked this pull request as ready for review September 12, 2022 10:09
@zoey-kaiser zoey-kaiser mentioned this pull request Sep 13, 2022
Merged
5 tasks
@aomafarag
Copy link
Contributor

General comment: Shouldn't the vault/ directory be placed under ~/components/auction/? Here, it's placed under ~/components/ directly.

aomafarag
aomafarag requested changes Sep 13, 2022
View reviewed changes
frontend/components/vault/VaultsTable.vue Outdated Show resolved Hide resolved
frontend/components/vault/VaultsTable.vue Outdated Show resolved Hide resolved
frontend/components/vault/VaultsTable.vue Outdated Show resolved Hide resolved
@zoey-kaiser
Copy link
Contributor Author

General comment: Shouldn't the vault/ directory be placed under ~/components/auction/? Here, it's placed under ~/components/ directly.

A vault is not a auction yet. Therefore I think it should not be in the auction directory. What do you think @valiafetisov?

@valiafetisov
Copy link
Contributor

A vault is not a auction yet. Therefore I think it should not be in the auction directory

Agree, let's put vault-related components into a separate folder

aomafarag
aomafarag previously approved these changes Sep 13, 2022
View reviewed changes
valiafetisov
valiafetisov reviewed Sep 20, 2022
View reviewed changes
frontend/components/vault/VaultsTable.vue Outdated Show resolved Hide resolved
frontend/helpers/generateFakeVault.ts Outdated Show resolved Hide resolved
valiafetisov
valiafetisov previously approved these changes Sep 20, 2022
View reviewed changes
@valiafetisov valiafetisov merged commit be5f7f6 into main Sep 20, 2022
@valiafetisov valiafetisov deleted the add-vaults-table branch September 20, 2022 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LukSteib LukSteib LukSteib approved these changes

@aomafarag aomafarag aomafarag left review comments

@valiafetisov valiafetisov valiafetisov left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create VaultLiquidationsTable component
4 participants
@zoey-kaiser @aomafarag @valiafetisov @LukSteib