Added VaultLiquidationTransactionTable and VaultLiquidationTransactionFlow
#454
Conversation
|
@valiafetisov, isn't there a description for the transaction fees already in the |
|
You can remove explainer over the |
frontend/components/auction/vault/VaultLiqudationTransactionTable.vue
Outdated
Show resolved
Hide resolved
frontend/components/auction/vault/VaultLiqudationTransactionTable.vue
Outdated
Show resolved
Hide resolved
zoey-kaiser
changed the title
VaultLiquidationTransactionTable component and storiesVaultLiquidationTransactionTable and VaultLiquidationTransactionFlow
frontend/components/vault/VaultLiquidationTransactionFlow.stories.js
Outdated
Show resolved
Hide resolved
|
It's of course better for the user to not suddenly hide anything, but in this case I think it's a good trade-off between UX and DX. In case vault is liquidated, I think it's fine to just hide everything in the page except for the title, close sign and the alert specifying what happened. The added value of the table that doesn't show anything and panels that doesn't work is very low. |
frontend/components/panels/VaultLiquidationLimitsCheckPanel.vue
Outdated
Show resolved
Hide resolved
frontend/components/panels/VaultLiquidationLimitsCheckPanel.vue
Outdated
Show resolved
Hide resolved
frontend/components/panels/VaultLiquidationLimitsCheckPanel.vue
Outdated
Show resolved
Hide resolved
| wasLiquidated(): boolean { | ||
| return this.vaultTransaction.state === 'liquidated'; | ||
| }, |
There was a problem hiding this comment.
I am not sure why types allow this check, since VaultTransactionNotLiquidated doesn't have this kind of state. Types doesn't work?
There was a problem hiding this comment.
Types in my IDE never worked, but I am surprised it was not caught in the CI. However the comment above should fix it!
There was a problem hiding this comment.
Types in my IDE never worked
OH WOW! Why was it never reported? Or did I miss it?
| vaultTransaction: { | ||
| type: Object as Vue.PropType<VaultTransaction>, | ||
| required: true, | ||
| }, | ||
| liquidationLimits: { | ||
| type: Object as Vue.PropType<LiquidationLimits>, | ||
| required: true, | ||
| }, |
There was a problem hiding this comment.
The liquidation limits are actually part of the vaultTransaction, but I guess you will fix it when you will put together the container 🙂
|
The other thing that will need to be updated soon the liquidated vault state: #460 (comment) |
Closes #437.
Checklist:
#)Missing
AnimatedArrowafter mergingExplaintexts