Integrate Bid Transactions into actual flow

[fegbert]

closes #125

[fegbert]

Couple of questions on some values:

Auction Minimum Bid: What actually is this value / where does it come from?

Allow access to DAI: Is this also setting isWalletAuthorised or is this doing something else?

AllowanceAmount: What's this used for / Do I use even this or is it for the wallet popup?

[valiafetisov]

Auction Minimum Bid: What actually is this value / where does it come from?

Good question, I think I forgot to fetch this value. Will open a new PR to add this value to each auction

Allow access to DAI: Is this also setting isWalletAuthorised or is this doing something else?

This is actually not a binary value as initially thought of, but a BigNumber. In the auth store it's called allowanceAmount. The value indicates how much DAI the user can deposit to VAT. So it should be not less then the minimum to deposit

[valiafetisov]

So the proposal for this PR is to:

• remove AccessDaiBlock from the transaction panel (since it's only needed if there is not enough DAI in the wallet)
• simplify DepositBlock by only leaving Manage DAI in VAT/Enough DAI is available button
• attach Manage DAI in VAT to the actual modal (when Add Wallet Popup Component #149 is merged)
• update stories
• provide correct loading states

[fegbert]

simplify DepositBlock by only leaving Manage DAI in VAT/Enough DAI is available button

Do I keep Minimum to deposit and the explanation text like proposed in the mock below or really only the button?

[valiafetisov]

Do I keep Minimum to deposit and the explanation text like proposed in the mock below or really only the button?

Sorry for the confusion. You can keep the Minimum to deposit and other values in the table too (balance and balance in VAT), requested change only affects the buttons. I've updated the mock above to reflect this.

[fegbert]

Any ideas already on how to mock the wallet popup / depositing stuff in the fake container and storybook? 🙂

[valiafetisov]

Any ideas already on how to mock the wallet popup / depositing stuff in the fake container and storybook?

Clicking it can just add enough DAI to participate, so you can basically skip the popup logic.

[fegbert]

As discussed in today's meeting, the bidding logic is still missing and the button currently just executes the same way as a swap transaction.

[valiafetisov]

Everything else looks good, the only thing left is to merge #163 and attach it to the button. If you're blocked, you can already do that (git merge bidding-with-dai-logic into your branch)

[LukSteib]

• The minimum to deposit amount in DepositBlock should update properly with each price drop (currently only after browser refresh)
• The finished auction state is not displayed properly. Bid button is still clickable (throwing an error) and the etherscan link is not displayed (see loom 1 below)

1
https://www.loom.com/share/cfaf4ba6abb54986a811015f64ff187d

[valiafetisov]

Bid button is still clickable (throwing an error) and the etherscan link is not displayed (see loom 1 below)

This should be probably done in #163
I removed transaction link because since we introduce partial bidding, there is a possibility that the user will bid part of the auction and we don't yet have logic to handle multiply transactions per auction 🙁

[LukSteib]

because since we introduce partial bidding, there is a possibility that the user will bid part of the auction and we don't yet have logic to handle multiply transactions per auction

Makes sense. Fine to remove it then for this flow for now.