-
Notifications
You must be signed in to change notification settings - Fork 565
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support cgroup deep analysis in talosctl
#9337
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
smira
changed the title
feat: supprot cgroup deep analysis in
feat: support cgroup deep analysis in Sep 18, 2024
talosctl
talosctl
smira
force-pushed
the
feat/cgroup-analysis
branch
from
September 19, 2024 16:57
d87c100
to
a3fe799
Compare
smira
added a commit
to smira/talos
that referenced
this pull request
Sep 19, 2024
Fixes: siderolabs#7081 Review all reservations and limits set, test under stress load (using both memory and CPU). The goal: system components (Talos itself) and runtime (kubelet, CRI) should survive under extreme resource starvation (workloads consuming all CPU/memory). Uses siderolabs#9337 to visualize changes, but doesn't depend on it. Signed-off-by: Andrey Smirnov <[email protected]>
smira
added a commit
to smira/talos
that referenced
this pull request
Sep 19, 2024
Fixes: siderolabs#7081 Review all reservations and limits set, test under stress load (using both memory and CPU). The goal: system components (Talos itself) and runtime (kubelet, CRI) should survive under extreme resource starvation (workloads consuming all CPU/memory). Uses siderolabs#9337 to visualize changes, but doesn't depend on it. Signed-off-by: Andrey Smirnov <[email protected]>
smira
added a commit
to smira/talos
that referenced
this pull request
Sep 20, 2024
Fixes: siderolabs#7081 Review all reservations and limits set, test under stress load (using both memory and CPU). The goal: system components (Talos itself) and runtime (kubelet, CRI) should survive under extreme resource starvation (workloads consuming all CPU/memory). Uses siderolabs#9337 to visualize changes, but doesn't depend on it. Signed-off-by: Andrey Smirnov <[email protected]>
smira
added a commit
to smira/talos
that referenced
this pull request
Sep 20, 2024
Fixes: siderolabs#7081 Review all reservations and limits set, test under stress load (using both memory and CPU). The goal: system components (Talos itself) and runtime (kubelet, CRI) should survive under extreme resource starvation (workloads consuming all CPU/memory). Uses siderolabs#9337 to visualize changes, but doesn't depend on it. Signed-off-by: Andrey Smirnov <[email protected]>
smira
added a commit
to smira/talos
that referenced
this pull request
Sep 20, 2024
Fixes: siderolabs#7081 Review all reservations and limits set, test under stress load (using both memory and CPU). The goal: system components (Talos itself) and runtime (kubelet, CRI) should survive under extreme resource starvation (workloads consuming all CPU/memory). Uses siderolabs#9337 to visualize changes, but doesn't depend on it. Signed-off-by: Andrey Smirnov <[email protected]>
smira
added a commit
to smira/talos
that referenced
this pull request
Sep 21, 2024
Fixes: siderolabs#7081 Review all reservations and limits set, test under stress load (using both memory and CPU). The goal: system components (Talos itself) and runtime (kubelet, CRI) should survive under extreme resource starvation (workloads consuming all CPU/memory). Uses siderolabs#9337 to visualize changes, but doesn't depend on it. Signed-off-by: Andrey Smirnov <[email protected]> (cherry picked from commit 6b15ca1)
smira
force-pushed
the
feat/cgroup-analysis
branch
2 times, most recently
from
September 27, 2024 16:02
e7471d5
to
96f4021
Compare
Preset cpu:
Preset cpuset:
Preset io:
Preset memory:
Preset process:
Preset swap:
|
The new command `talosctl cgroups` fetches cgroups snapshot from the machine, parses it fully, enhances with additional information (e.g. resolves pod names), and presents a customizable view of cgroups configuration (e.g. limits) and current consumption. Signed-off-by: Andrey Smirnov <[email protected]>
smira
force-pushed
the
feat/cgroup-analysis
branch
from
September 30, 2024 14:57
96f4021
to
908fd87
Compare
Unix4ever
approved these changes
Sep 30, 2024
/m |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new command
talosctl cgroups
fetches cgroups snapshot from the machine, parses it fully, enhances with additional information (e.g. resolves pod names), and presents a customizable view of cgroups configuration (e.g. limits) and current consumption.Missing bits:
Sample output: