feat: runc memfd-bind service #9069
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frezbo
commented
Jul 26, 2024
smira
reviewed
Jul 26, 2024
internal/app/machined/pkg/runtime/v1alpha1/v1alpha1_sequencer_tasks.go
Outdated
Show resolved
Hide resolved
smira
approved these changes
Jul 26, 2024
frezbo
force-pushed
the
feat/runc-memfd
branch
2 times, most recently
from
f2e00fb
to
25f1694
Compare
Add a `runc-memfd-bind` service so that runc binary is not copied for every `runc` invocation. Fixes: siderolabs#9007. Signed-off-by: Noel Georgi <[email protected]>
|
/m |
frezbo
added a commit
to frezbo/talos
that referenced
this pull request
Oct 31, 2024
As of runc 1.2.0, it internally uses an `ovverlay` mount instead of cloning `/proc/self/exe` and https://github.com/opencontainers/runc/pull/4482/files drops and the `DMZ` code. This also reduces code that Talos has to maintain. Signed-off-by: Noel Georgi <[email protected]>
frezbo
added a commit
to frezbo/talos
that referenced
this pull request
Nov 1, 2024
As of runc 1.2.0, it internally uses an `ovverlay` mount instead of cloning `/proc/self/exe` and https://github.com/opencontainers/runc/pull/4482/files drops and the `DMZ` code. This also reduces code that Talos has to maintain. Signed-off-by: Noel Georgi <[email protected]>
frezbo
added a commit
to frezbo/talos
that referenced
this pull request
Nov 1, 2024
As of runc 1.2.0, it internally uses an `ovverlay` mount instead of cloning `/proc/self/exe` and https://github.com/opencontainers/runc/pull/4482/files drops and the `DMZ` code. This also reduces code that Talos has to maintain. Fixes: siderolabs#9543 Signed-off-by: Noel Georgi <[email protected]>
frezbo
added a commit
to frezbo/talos
that referenced
this pull request
Nov 1, 2024
As of runc 1.2.0, it internally uses an `ovverlay` mount instead of cloning `/proc/self/exe` and https://github.com/opencontainers/runc/pull/4482/files drops and the `DMZ` code. This also reduces code that Talos has to maintain. Fixes: siderolabs#9543 Signed-off-by: Noel Georgi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a
runc-memfd-bindservice so that runc binary is not copied for everyruncinvocation.Fixes: #9007.