Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: bump k8s to v0.25.0-beta.0 #5879

Merged
merged 1 commit into from
Aug 10, 2022
Merged

feat: bump k8s to v0.25.0-beta.0 #5879

merged 1 commit into from
Aug 10, 2022

Conversation

frezbo
Copy link
Member

@frezbo frezbo commented Jul 8, 2022 •
edited
Loading

Bump k8s to v0.25.0-beta.0

Signed-off-by: Noel Georgi [email protected]

This change is Reviewable

@frezbo
Copy link
Member Author

frezbo commented Jul 8, 2022

Updated:

Skipped changes:

  • renaming of k8s.gcr.io to registry.k8s.io is skipped now, since the pause image that's defined in containerd repo is still using k8s.gcr.io
  • PodSecurity admission plugin version is still kept at pod-security.admission.config.k8s.io/v1alpha1 since talos 1.2 has to support n-2 k8s versions

TODO:

  • PodSecurityPolicy admission plugin is removed in 1.25, this probably needs some handling in machine config
  • stop applying the "node-role.kubernetes.io/master:NoSchedule" taint to control plane nodes for new clusters. Remove the taint from existing control plane nodes during upgrades? (kubeadm does this)

@frezbo frezbo force-pushed the chore/bump-k8s-1.25-alpha branch from 39405c7 to 4d77606 Compare July 8, 2022 21:09
@smira
Copy link
Member

smira commented Jul 11, 2022

PodSecurityPolicy admission plugin is removed in 1.25, this probably needs some handling in machine config

we already default to disabling PSP, we can remove it completely with 1.27 I guess?

smira
smira approved these changes Jul 11, 2022
View reviewed changes
Copy link
Member

@smira smira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@frezbo
Copy link
Member Author

frezbo commented Jul 11, 2022

we already default to disabling PSP, we can remove it completely with 1.27 I guess?

Should i remove it from machineconfig all together?

@smira
Copy link
Member

smira commented Jul 11, 2022

Should i remove it from machineconfig all together?

please, no, Talos validates machine config on unknown keys, so we can't do that this way... at least let's not pull the plug right now

@frezbo frezbo force-pushed the chore/bump-k8s-1.25-alpha branch 2 times, most recently from 9a733f6 to 1887106 Compare July 11, 2022 18:48
@frezbo
Copy link
Member Author

frezbo commented Jul 11, 2022

/promote e2e

@frezbo frezbo force-pushed the chore/bump-k8s-1.25-alpha branch from 1887106 to 51bcc8f Compare July 11, 2022 19:48
@frezbo
Copy link
Member Author

frezbo commented Jul 11, 2022

/promote e2e

@frezbo
Copy link
Member Author

frezbo commented Jul 11, 2022

/promote e2e-aws

1 similar comment
@frezbo
Copy link
Member Author

frezbo commented Jul 12, 2022

/promote e2e-aws

@frezbo
Copy link
Member Author

frezbo commented Jul 12, 2022

Will try to do PR's to calico and aws cloud controller rather than implementing hacks

@frezbo
Copy link
Member Author

frezbo commented Jul 12, 2022

Calico PR projectcalico/calico#6370

@frezbo frezbo force-pushed the chore/bump-k8s-1.25-alpha branch 2 times, most recently from c8223bc to 4eaea4b Compare July 20, 2022 17:26
@smira
Copy link
Member

smira commented Jul 20, 2022

btw, there's already alpha.3 available ;)

@frezbo frezbo force-pushed the chore/bump-k8s-1.25-alpha branch 2 times, most recently from 90ce522 to 55c992e Compare July 23, 2022 09:23
@frezbo frezbo force-pushed the chore/bump-k8s-1.25-alpha branch from 55c992e to 42841b2 Compare August 5, 2022 16:07
@frezbo
Copy link
Member Author

frezbo commented Aug 5, 2022

/promote e2e

@frezbo frezbo changed the title chore: bump k8s to v0.25.0-alpha.2 chore: bump k8s to v0.25.0-beta.0 Aug 5, 2022
@frezbo frezbo force-pushed the chore/bump-k8s-1.25-alpha branch from 42841b2 to d105861 Compare August 5, 2022 18:42
@frezbo
Copy link
Member Author

frezbo commented Aug 5, 2022

/promote e2e

@frezbo frezbo force-pushed the chore/bump-k8s-1.25-alpha branch from d105861 to e39257f Compare August 5, 2022 19:56
@frezbo
Copy link
Member Author

frezbo commented Aug 5, 2022

/promote e2e-aws

@frezbo frezbo force-pushed the chore/bump-k8s-1.25-alpha branch from e39257f to 1021886 Compare August 5, 2022 20:32
@frezbo frezbo force-pushed the chore/bump-k8s-1.25-alpha branch 4 times, most recently from 1a9fc5d to 2779834 Compare August 9, 2022 20:15
@frezbo
Copy link
Member Author

frezbo commented Aug 9, 2022

/promote e2e

@frezbo
Copy link
Member Author

frezbo commented Aug 9, 2022

/promote integration

@frezbo frezbo force-pushed the chore/bump-k8s-1.25-alpha branch 3 times, most recently from 118f815 to 235b7d5 Compare August 10, 2022 05:53
@frezbo
Copy link
Member Author

frezbo commented Aug 10, 2022

/promote integration-qemu-csi

@frezbo frezbo force-pushed the chore/bump-k8s-1.25-alpha branch 2 times, most recently from 14bde5d to 66ac99f Compare August 10, 2022 15:00
@frezbo
Copy link
Member Author

frezbo commented Aug 10, 2022

/promote integration-qemu-csi

@frezbo
Copy link
Member Author

frezbo commented Aug 10, 2022

/promote integration-qemu

@frezbo
Copy link
Member Author

frezbo commented Aug 10, 2022

/promote integration-qemu-race

@frezbo
feat: bump k8s to v1.25.0-beta.0
b62b18a 
Bump k8s to v1.25.0-beta.0

Update most kubernetes `master` references to `controlplane`

Signed-off-by: Noel Georgi <[email protected]>
@frezbo frezbo force-pushed the chore/bump-k8s-1.25-alpha branch from 66ac99f to b62b18a Compare August 10, 2022 16:48
@frezbo
Copy link
Member Author

frezbo commented Aug 10, 2022

/promote integration-qemu-race

@frezbo
Copy link
Member Author

frezbo commented Aug 10, 2022

/m

@talos-bot talos-bot merged commit b62b18a into siderolabs:master Aug 10, 2022
@frezbo frezbo deleted the chore/bump-k8s-1.25-alpha branch August 10, 2022 18:19
smira added a commit to smira/talos that referenced this pull request Sep 14, 2022
@smira
fix: set etcd options consistently
94b088f 
This fixes an issue introduced in siderolabs#5879: options should be set same way
for both `init` and `controlplane` cases.

Signed-off-by: Andrey Smirnov <[email protected]>
@smira smira mentioned this pull request Sep 14, 2022
Merged
sanmai-NL pushed a commit to sanmai-NL/talos that referenced this pull request Sep 15, 2022
@smira @sanmai-NL
fix: set etcd options consistently
0f9c434 
This fixes an issue introduced in siderolabs#5879: options should be set same way
for both `init` and `controlplane` cases.

Signed-off-by: Andrey Smirnov <[email protected]>
smira added a commit to smira/talos that referenced this pull request Sep 20, 2022
@smira
fix: set etcd options consistently
1d7d8d5 
This fixes an issue introduced in siderolabs#5879: options should be set same way
for both `init` and `controlplane` cases.

Signed-off-by: Andrey Smirnov <[email protected]>
(cherry picked from commit 94b088f)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smira smira smira approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@frezbo @smira @talos-bot