-
Notifications
You must be signed in to change notification settings - Fork 611
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 initialManifests not working as expected #7993
Comments
…tents In route `LoadPatches` -> `configpatcher.Apply` -> `configloader.NewFromBytes` it will transform leading newline into `|4` yaml. Closes siderolabs#7993 Signed-off-by: Dmitriy Matrenichev <[email protected]>
…tents In route `LoadPatches` -> `configpatcher.Apply` -> `configloader.NewFromBytes` any leading newlines will be transformed into `|4` yaml. We want to prevent that. Closes siderolabs#7993 Signed-off-by: Dmitriy Matrenichev <[email protected]>
Hey! Thanks for the report. I believe the culprit is here: ...
contents: |
--
apiVersion: v1
... Removing this newline before |
…tents In route `LoadPatches` -> `configpatcher.Apply` -> `configloader.NewFromBytes` any leading newlines will be transformed into `|4` yaml. We want to prevent that. Closes siderolabs#7993 Signed-off-by: Dmitriy Matrenichev <[email protected]>
@wibed If you don't mind - how did you generate this patch? Manually? The reason I'm asking is that I'm curious we we are inserting this newlines ourselves somewhere. |
yes i did a "create-patch-command" (might be a cat idr) >> patch.yaml |
In route `LoadPatches` -> `configpatcher.Apply` -> `configloader.NewFromBytes` any leading newlines will be transformed into `|4` yaml. We want to prevent that. Closes siderolabs#7993 Signed-off-by: Dmitriy Matrenichev <[email protected]>
Can you elaborate on that? |
In route `LoadPatches` -> `configpatcher.Apply` -> `configloader.NewFromBytes` any leading newlines will be transformed into `|4` yaml. We want to prevent that. Closes siderolabs#7993 Signed-off-by: Dmitriy Matrenichev <[email protected]>
In route `LoadPatches` -> `configpatcher.Apply` -> `configloader.NewFromBytes` any leading newlines will be transformed into `|4` yaml. We want to prevent that. Closes siderolabs#7993 Signed-off-by: Dmitriy Matrenichev <[email protected]> (cherry picked from commit eecc4db)
i get mapping errors trying to install manifests on bootstrap
first error:
cleaned the file with the online tool:
https://validkube.com
there was a empty
resources: []
generated somewherethen the error changed into:
it worked with a helm install right of the bat.
the patch.yaml
The text was updated successfully, but these errors were encountered: