feat: implement Talos kernel log receiver #650
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👷 Deploy request for wonderful-swartz-a1308c pending review. 🔨 Explore the source changes: ab12b81 |
|
/approve |
Unix4ever
reviewed
Nov 29, 2021
| @@ -405,14 +407,21 @@ func newEnvironmentFromServerClass(serverBinding *infrav1.ServerBinding) (env *m | |||
| } | |||
|
|
|||
| func appendTalosArguments(env *metalv1alpha1.Environment) { | |||
| if sideroLinkConfig.ServerAddress.IsZero() { | |||
There was a problem hiding this comment.
Maybe can load it in newEnvironment call. Then it will be possible to handle an error there.
There was a problem hiding this comment.
yeah, it's weird. we can't load before mgr is started, as client is not initialized yet.
we don't have a good pre-hook for it. probably we can put it to some errgroup in main
There was a problem hiding this comment.
I ended using mgr.Add in main.go
Fixes siderolabs#527 Talos logs (see siderolabs/talos#4600) are delivered to Sidero over the SideroLink tunnel. Logs can be seen with: ``` $ kubectl logs -n sidero-system deployment/sidero-controller-manager -c serverlogs -f {"clock":67194673,"cluster":"management-cluster","facility":"user","machine":"default/management-cluster-cp-4j8f4","metal_machine":"default/management-cluster-cp-hbq57","msg":"[talos] phase bootloader (19/19): done, 176.795226ms\n","priority":"warning","seq":768,"server_uuid":"5b72932a-c482-4aa5-b00e-4b8773d3ac48","talos-level":"warn","talos-time":"2021-11-26T19:34:42.444342392Z"} ``` Logs are annotated on the fly with the information about `Server`, `MetalMachine`, `Machine` and `Cluster`. Signed-off-by: Andrey Smirnov <[email protected]>
Unix4ever
approved these changes
Dec 1, 2021
|
/m --ff |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #527
Talos logs (see siderolabs/talos#4600) are
delivered to Sidero over the SideroLink tunnel.
Logs can be seen with:
Logs are annotated on the fly with the information about
Server,MetalMachine,MachineandCluster.Signed-off-by: Andrey Smirnov [email protected]