Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: surround IPv6 addresses with brackets #1116

Closed
wants to merge 1 commit into from

Conversation

lion7
Copy link
Contributor

@lion7 lion7 commented Apr 28, 2023

The host IP address is passed to netip.ParseAddrPort, which returns an error if IPv6 addresses are not surrounded in brackets. This happens when the Kubernetes node has an IPv6 address. Errors I saw in my logs:

❯ kubectl logs -n sidero-system sidero-controller-manager-64788bbf65-w42f7 siderolink 
I0428 12:29:44.434812       1 request.go:601] Waited for 1.04738863s due to client-side throttling, not priority and fairness, request: GET:https://[2a02:****:****:1000::11:1]:443/apis/cilium.io/v2?timeout=32s
error: invalid Wireguard endpoint: invalid ip:port "2a02:****:****:0:d250:99ff:fefa:a836:51821", IPv6 addresses must be surrounded by square brackets

@netlify
Copy link

netlify bot commented Apr 28, 2023

👷 Deploy request for wonderful-swartz-a1308c pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 12fc6a3

@smira
Copy link
Member

smira commented May 3, 2023

@lion7 thanks for reporting this, I have a simpler fix in #1122

@talos-bot talos-bot closed this in 45ac3d8 May 3, 2023
@lion7 lion7 deleted the siderolink branch June 21, 2023 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants