-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add health checks to all controllers #560
Comments
any update on this, we met this problem again:
|
We are going to take a look today. It's a bug that controller doesn't crash |
I don't think liveness check is the right answer here though, as controller being working is hard to check from outside. |
smira
added a commit
to smira/sidero
that referenced
this issue
Sep 17, 2021
Fixes siderolabs#560 The way it was implemented before this change, `errgoup` waits for all goroutines to finish before it returns, so if the controller crashes due to election issues, container still keeps running as HTTP API is up. After this change, container crashes on first error. Also added liveness/readiness check, they won't help much this issue, but provide additional layer of protection/visibility. Signed-off-by: Andrey Smirnov <[email protected]> (cherry picked from commit e52071d)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
We should add readiness and liveness problem to all controllers.
The text was updated successfully, but these errors were encountered: