Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Agent extra args are space delimited? #502

Closed
andrewrynhard opened this issue Jul 9, 2021 · 0 comments · Fixed by #635
Closed

Agent extra args are space delimited? #502

andrewrynhard opened this issue Jul 9, 2021 · 0 comments · Fixed by #635
Assignees
@smira

Comments

@andrewrynhard
Copy link
Member

https://github.com/talos-systems/sidero/blob/6821dd2c0a111ab5a6966d4b73679deb961b3026/app/sidero-controller-manager/main.go#L89 says comma, but looks like the arg gets injected verbatim.
@smira smira self-assigned this Nov 15, 2021
smira added a commit to smira/sidero that referenced this issue Nov 15, 2021
@smira
docs: update help message for extra kernel args
5c070c7 
Fixes siderolabs#502

The value is simply parsed as Linux kernel command line arguments.

Signed-off-by: Andrey Smirnov <[email protected]>
@smira smira mentioned this issue Nov 15, 2021
Merged
smira added a commit to smira/sidero that referenced this issue Nov 15, 2021
@smira
docs: update help message for extra kernel args
40c9360 
Fixes siderolabs#502

The value is simply parsed as Linux kernel command line arguments.

Signed-off-by: Andrey Smirnov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@smira smira

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

docs: update help message for extra kernel args smira/sidero
2 participants
@smira @andrewrynhard