Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

node address filtering support #1368

Closed
abckey opened this issue May 21, 2024 · 0 comments · Fixed by #1369
Closed

node address filtering support #1368

abckey opened this issue May 21, 2024 · 0 comments · Fixed by #1369
Assignees

Comments

@abckey
Copy link

abckey commented May 21, 2024

talos reports all available IPs on the node to sidero metal, including some internal IPs are not reachable outside.

those IPs are populated to Machine object, CACPPT then takes 1st IP to use to do etcd bootstrap.

When 1st IP is a non-routable internal IP, then etcd bootstrap fails.

 # kubectl -n <namespace> get machine <machine name> -o yaml|yq -y .status.addresses
- address: 10.10.10.1
  type: InternalIP
- address: 10.20.20.1
  type: InternalIP
- address: 167.183.1183.31
  type: InternalIP
- address: hostabcde
  type: Hostname

The problem can be solved by setting excluding filters to exclude IPs from certain network ranges, e.g. following filters can exclude 10.10.10.1 and 10.20.20.1 from above reported list:

- 10.10.10.0/24
- 10.20.20.0/31
@smira smira self-assigned this May 23, 2024
smira added a commit to smira/sidero that referenced this issue May 23, 2024
This allows to filter out addresses reported by Talos machines to
SideroMetal and which appear under `Machine.status.addresses`.

Fixes siderolabs#1368

Signed-off-by: Andrey Smirnov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants