feat(rk3588): add overlay option to disable uBoot installation for SPI Flash boot #49
+78
−68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schneid-l
force-pushed
the
feat/rk3588-disable-uboot-for-spi-boot
branch
from
c8a6176 to
91550cc
Compare
Signed-off-by: Louis SCHNEIDER <[email protected]>
Signed-off-by: Louis SCHNEIDER <[email protected]>
Signed-off-by: Louis SCHNEIDER <[email protected]>
Signed-off-by: Louis SCHNEIDER <[email protected]>
schneid-l
force-pushed
the
feat/rk3588-disable-uboot-for-spi-boot
branch
from
91550cc to
5a0806a
Compare
frezbo
reviewed
Jan 24, 2025
| @@ -41,7 +41,7 @@ steps: | |||
| install: | |||
| - | | |||
| mkdir -p /rootfs/artifacts/arm64/u-boot/orangepi-5 | |||
| cp -v -t /rootfs/artifacts/arm64/u-boot/orangepi-5 u-boot-rockchip.bin | |||
| cp -v -t /rootfs/artifacts/arm64/u-boot/orangepi-5 u-boot-rockchip.bin u-boot-rockchip-spi.bin | |||
There was a problem hiding this comment.
is this just copying the same file to different name?
frezbo
reviewed
Jan 24, 2025
| @@ -27,7 +27,9 @@ func main() { | |||
|
|
|||
| type opi5Installer struct{} | |||
|
|
|||
| type opi5ExtraOptions struct{} | |||
| type opi5ExtraOptions struct { | |||
| SPIBoot bool | |||
There was a problem hiding this comment.
was this tested, this is missing yaml tags and won't work
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for disabling uBoot installation on rk3588 boards.
Overview
This PR introduces a new overlay option for rk3588 boards (Turing Pi RK1, Orange Pi 5, and ROCK 5B) to disable the installation of uBoot during the setup process.
Additionally, it renames the Orange Pi 5 board from
opi5toorangepi-5for consistency with the naming conventions of other Orange Pi boards.Changes
opi5toorangepi-5.Motivation
rk3588 boards include SPI Flash, enabling uBoot to be pre-flashed. For users who wish to boot from alternate devices such as NVMe or USB drives, this flexibility eliminates the need for uBoot installation on the disk.