feat: implement skipPaths option for 'license' policy
#121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smira
force-pushed
the
implement-skip-paths
branch
from
929a2b5 to
e646c56
Compare
smira
added a commit
to smira/talos
that referenced
this pull request
Apr 10, 2019
This allows buildkitd cache to be reused when buildkitd container is restarted. In CI, this directory could be shared between the builds to speed them up. Depends on new conform (siderolabs/conform#121) to skip `.builkit/` directory as it contains root-owned files which are not readable. Signed-off-by: Andrey Smirnov <[email protected]>
smira
force-pushed
the
implement-skip-paths
branch
15 times, most recently
from
dd6cf4b to
64e793c
Compare
smira
commented
Apr 11, 2019
| @@ -3,7 +3,7 @@ policies: | |||
| spec: | |||
| headerLength: 89 | |||
| dco: true | |||
| gpg: true | |||
| gpg: false | |||
There was a problem hiding this comment.
switched it off to make make enforce pass on the repo itself
smira
commented
Apr 11, 2019
| @@ -19,30 +19,34 @@ build: | |||
| -t conform/$@:$(TAG) \ | |||
| --target=$@ \ | |||
| $(COMMON_ARGS) | |||
| @docker run --rm -it -v $(PWD)/build:/build conform/$@:$(TAG) cp /conform-linux-amd64 /build | |||
| @docker run --rm -it -v $(PWD)/build:/build conform/$@:$(TAG) cp /conform-darwin-amd64 /build | |||
There was a problem hiding this comment.
-it shouldn't be there (breaks as there's no TTY in drone)
smira
commented
Apr 11, 2019
|
|
||
| image: build | ||
| @docker build \ | ||
| -t autonomy/conform:$(TAG) \ | ||
| --target=$@ \ | ||
| $(COMMON_ARGS) | ||
|
|
||
| .PHONY: login | ||
| login: | ||
| @docker login --username $(DOCKER_USERNAME) --password $(DOCKER_PASSWORD) |
smira
commented
Apr 11, 2019
| push: image | ||
| @docker tag autonomy/conform:$(TAG) autonomy/conform:latest | ||
| @docker push autonomy/conform:$(TAG) | ||
| @docker push autonomy/conform:latest | ||
|
|
||
| deps: | ||
| @GO111MODULES=on CGO_ENABLED=0 go get -u github.com/autonomy/gitmeta | ||
| @GO111MODULES=on CGO_ENABLED=0 go get -u github.com/autonomy/conform | ||
| @GO111MODULE=on CGO_ENABLED=0 go get -u github.com/autonomy/gitmeta |
smira
commented
Apr 11, 2019
| report.Errors = append(report.Errors, errors.Errorf("failed to get commit message: %v", err)) | ||
| return | ||
| } | ||
| } else if msg, err = g.Message(); err != nil { |
There was a problem hiding this comment.
linter thinks it's better, I don't quite agree...
This allows to skip directories which shouldn't be checked (e.g. `.git/`) or directories which aren't readable. While I was at it, bumped Go version, golangci-lint, refactored tests to avoid duplicated code and make linter happy. Rearranged a bit `Dockerfile` to avoid `go mod download` when `go.mod` is not changed. Signed-off-by: Andrey Smirnov <[email protected]>
smira
force-pushed
the
implement-skip-paths
branch
from
64e793c to
30b2a41
Compare
bradbeam
approved these changes
Apr 11, 2019
smira
added a commit
to smira/talos
that referenced
this pull request
Apr 12, 2019
This allows buildkitd cache to be reused when buildkitd container is restarted. In CI, this directory could be shared between the builds to speed them up. Depends on new conform (siderolabs/conform#121) to skip `.builkit/` directory as it contains root-owned files which are not readable. Signed-off-by: Andrey Smirnov <[email protected]>
smira
added a commit
to smira/talos
that referenced
this pull request
Apr 12, 2019
This allows buildkitd cache to be reused when buildkitd container is restarted. In CI, this directory could be shared between the builds to speed them up. Depends on new conform (siderolabs/conform#121) to skip `.builkit/` directory as it contains root-owned files which are not readable. Signed-off-by: Andrey Smirnov <[email protected]>
smira
added a commit
to smira/talos
that referenced
this pull request
Apr 12, 2019
This allows buildkitd cache to be reused when buildkitd container is restarted. In CI, this directory could be shared between the builds to speed them up. Depends on new conform (siderolabs/conform#121) to skip `.builkit/` directory as it contains root-owned files which are not readable. Signed-off-by: Andrey Smirnov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows to skip directories which shouldn't be checked (e.g.
.git/) or directories which aren't readable.While I was at it, bumped Go version, golangci-lint, refactored tests to
avoid duplicated code and make linter happy.
Rearranged a bit
Dockerfileto avoidgo mod downloadwhengo.modis not changed.
Signed-off-by: Andrey Smirnov [email protected]