You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When creating control-plane and worker machines at the same time, for example by doing something along the lines of the following, cabpt can decide to generate the ${CLUSTER_NAME}-ca secret (TalosConfigReconciler.writeK8sCASecret) based on a workers machineconfig, thus containing an empty tls.key. This in turn causes trouble when generating the ${CLUSTER_NAME}-kubeconfig secret.
In my use case I'm using TalosConfigTemplate with generateType: none and data set to a full config.
Speculation on solutions could include:
checking for type to be init or controlplane before deciding to generate the secret
checking for the Machine to have a TalosControlPlane as ownerRefence
checking for the Machine to have a 'anything in the controlplane.cluster.x-k8s.io/v1alpha3 namespace as ownerReference, for if someone invents a reason to use cabpt without cacppt.
The text was updated successfully, but these errors were encountered:
Fixessiderolabs#97
Skip creating the secret if the supplied user config doesn't have full
cluster CA. Cluster secret will be created once the controlplane machine
configuration is passed in.
Signed-off-by: Andrey Smirnov <[email protected]>
(cherry picked from commit 8c7fec8)
When creating control-plane and worker machines at the same time, for example by doing something along the lines of the following, cabpt can decide to generate the
${CLUSTER_NAME}-ca
secret (TalosConfigReconciler.writeK8sCASecret
) based on a workers machineconfig, thus containing an emptytls.key
. This in turn causes trouble when generating the${CLUSTER_NAME}-kubeconfig
secret.In my use case I'm using
TalosConfigTemplate
withgenerateType: none
anddata
set to a full config.Speculation on solutions could include:
type
to beinit
orcontrolplane
before deciding to generate the secretMachine
to have aTalosControlPlane
as ownerRefencecontrolplane.cluster.x-k8s.io/v1alpha3
namespace as ownerReference, for if someone invents a reason to use cabpt without cacppt.The text was updated successfully, but these errors were encountered: