Add ability to configure the past scheduled time threshold #465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems fine @fatkodima ✅ Let's leave it open some days, so we can think a bit on the naming. |
|
Maybe something like "reschedule grace period" would make more sense in terms of naming. |
|
Like it @kevinrobell-st! What's your thoughts @fatkodima? |
fatkodima
force-pushed
the
past_scheduled_time_threshold
branch
from
290c678 to
334eef9
Compare
|
Like it! Switched to that name, thank you ❤️ |
markets
approved these changes
Apr 22, 2024
|
Thanks @fatkodima 🙌 |
|
Hey @markets, is it planned to cut a release with the changes from this PR? |
|
Hopefully soon! In the meantime, you can point the gem to GitHub gem 'sidekiq-cron', github: 'sidekiq-cron/sidekiq-cron' |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #463.
Naming is hard, so probably people can suggest a better name for this configuration option.
I also refactored a bit the relevant methods to avoid double negation and be simpler to understand.