Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix section content type #64

Merged
merged 1 commit into from
Sep 29, 2023
Merged

Fix section content type #64

merged 1 commit into from
Sep 29, 2023

Conversation

smigles
Copy link
Contributor

@smigles smigles commented Sep 25, 2023

The section content type is always string, never undefined.

I could use the empty string (content: '') instead of as Section when adding a section object. But this is unnecessary output code because the slice method overwrites the empty string.

@siddharthvp siddharthvp merged commit b83b0ae into siddharthvp:master Sep 29, 2023
@siddharthvp
Copy link
Owner

Indeed.

@smigles smigles deleted the fix-section-content-type branch September 29, 2023 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants