Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only retry requests with relevant HTTP error codes in responses #24

Merged
merged 1 commit into from
Jan 21, 2022
Merged

Only retry requests with relevant HTTP error codes in responses #24

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/core.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -381,7 +381,12 @@ export class Response {
!error.disableRetry &&
this.requestOptions.retryNumber < this.bot.options.maxRetries &&
// ENOTFOUND usually means bad apiUrl is provided, retrying is pointless and annoying
error.code !== 'ENOTFOUND'
error.code !== 'ENOTFOUND' &&
(
!error.response?.status ||
// Vaguely retriable error codes
[408, 409, 425, 429, 500, 502, 503, 504].includes(error.response.status)
)
) {
// error might be transient, give it another go!
log(`[W] Encountered ${error}, retrying in ${this.bot.options.retryPause / 1000} seconds`);
Expand Down