Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(icons): add support for custom icons in menu #455

Merged
merged 5 commits into from
Feb 26, 2023

Conversation

jorgeucano
Copy link
Contributor

@jorgeucano jorgeucano commented Feb 14, 2023

This PR contains:

  • bugfix
  • feature
  • refactor
  • tests
  • documentation
  • others

Breaking Changes?

  • yes
  • no

Checklist

  • commit messages follow the Conventional Commits pattern
    • A feature commit message is prefixed "feat:"
    • A bugfix commit message is prefixed "fix:"
    • A document related commit is prefixed "docs:"
  • docs have been added / updated (for bug fixes / features)

Describe Your Changes

Add support for custom icons for add into the forRoot
ie

      locals: {
        bold: 'This is bold',
      },
      icons: {
        bold: '<img src="https://cdn-icons-png.flaticon.com/512/1827/1827924.png " width="15" height="15" alt="" title="" class="img-small">',
      },
    })

Does this PR affects any existing issues?

  • yes
  • no

@jorgeucano
Copy link
Contributor Author

hey @sibiraj-s what do you think about the pr ??

@sibiraj-s
Copy link
Owner

Hi, @jorgeucano Thanks for creating the PR. Will check this tomorrow or the day after. I am stuck with some personal work.

Overall it looks good to me, let me check this later once again.

@sibiraj-s
Copy link
Owner

Also please update the docs somewhere as you see fit. And, I also have left some overall comments. hope it makes sense.

Thanks again @jorgeucano.

@jorgeucano
Copy link
Contributor Author

thanks for review the pr I made the changes and response some questions! all is commited now!

@sibiraj-s
Copy link
Owner

Changes looks good. Please add few test cases for the code. Thank you.

let me know if any help is needed there.

@jorgeucano
Copy link
Contributor Author

@sibiraj-s I added the test too!

@sibiraj-s
Copy link
Owner

@sibiraj-s I added the test too!

I will publish this today or by Sunday.

Thanks again @jorgeucano

@sibiraj-s sibiraj-s merged commit 5706bc4 into sibiraj-s:master Feb 26, 2023
@github-actions
Copy link

github-actions bot commented Apr 2, 2023

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in the thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants