-
-
Notifications
You must be signed in to change notification settings - Fork 190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(icons): add support for custom icons in menu #455
Conversation
hey @sibiraj-s what do you think about the pr ?? |
Hi, @jorgeucano Thanks for creating the PR. Will check this tomorrow or the day after. I am stuck with some personal work. Overall it looks good to me, let me check this later once again. |
projects/ngx-editor/src/lib/modules/menu/toggle-command/toggle-command.component.ts
Outdated
Show resolved
Hide resolved
projects/ngx-editor/src/lib/modules/menu/bubble/bubble.component.ts
Outdated
Show resolved
Hide resolved
projects/ngx-editor/src/lib/modules/menu/color-picker/color-picker.component.ts
Show resolved
Hide resolved
Also please update the docs somewhere as you see fit. And, I also have left some overall comments. hope it makes sense. Thanks again @jorgeucano. |
thanks for review the pr I made the changes and response some questions! all is commited now! |
Changes looks good. Please add few test cases for the code. Thank you. let me know if any help is needed there. |
@sibiraj-s I added the test too! |
Co-authored-by: Sibiraj <[email protected]>
I will publish this today or by Sunday. Thanks again @jorgeucano |
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in the thread. |
This PR contains:
Breaking Changes?
Checklist
Describe Your Changes
Add support for custom icons for add into the forRoot
ie
Does this PR affects any existing issues?