Skip to content

Commit

Permalink
Fix debug compile error for csv_test.cpp (rapidsai#8981)
Browse files Browse the repository at this point in the history
Found an compile error in `csv_test.cpp` that only occurs with a debug build since it exists in an `assert()` statement.
Looks like this was introduced in PR rapidsai#8856

Authors:
  - David Wendt (https://github.com/davidwendt)

Approvers:
  - Vukasin Milovanovic (https://github.com/vuule)
  - Mike Wilson (https://github.com/hyperbolic2346)

URL: rapidsai#8981
  • Loading branch information
davidwendt authored and shwina committed Aug 9, 2021
1 parent 44ae850 commit 740d354
Showing 1 changed file with 5 additions and 5 deletions.
10 changes: 5 additions & 5 deletions cpp/tests/io/csv_test.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -415,7 +415,7 @@ TYPED_TEST(CsvFixedPointWriterTest, SingleColumnNegativeScale)
result_strings.reserve(reference_strings.size());

std::ifstream read_result_file(filepath);
assert(read_result_file.is_open());
ASSERT_TRUE(read_result_file.is_open());

std::copy(std::istream_iterator<std::string>(read_result_file),
std::istream_iterator<std::string>(),
Expand Down Expand Up @@ -461,7 +461,7 @@ TYPED_TEST(CsvFixedPointWriterTest, SingleColumnPositiveScale)
result_strings.reserve(reference_strings.size());

std::ifstream read_result_file(filepath);
assert(read_result_file.is_open());
ASSERT_TRUE(read_result_file.is_open());

std::copy(std::istream_iterator<std::string>(read_result_file),
std::istream_iterator<std::string>(),
Expand Down Expand Up @@ -2175,9 +2175,9 @@ TEST_F(CsvReaderTest, DtypesMap)
auto result = cudf_io::read_csv(in_opts);

const auto result_table = result.tbl->view();
assert(result_table->num_columns() == 2);
assert(result_table.column(0).type() == data_type{type_id::INT32});
assert(result_table.column(1).type() == data_type{type_id::INT16});
ASSERT_EQ(result_table.num_columns(), 2);
ASSERT_EQ(result_table.column(0).type(), data_type{type_id::INT32});
ASSERT_EQ(result_table.column(1).type(), data_type{type_id::INT16});
expect_column_data_equal(std::vector<int32_t>{12, 34, 56}, result_table.column(0));
expect_column_data_equal(std::vector<int16_t>{9, 8, 7}, result_table.column(1));
}
Expand Down

0 comments on commit 740d354

Please sign in to comment.