Early exit in scrollToOffset if contentOffset wouldn't change (micros…

…oft#1486) Summary: changelog: [internal] Calling `scrollToOffset` with already set content offset doesn't make sense. Reviewed By: cipolleschi Differential Revision: D38499666 fbshipit-source-id: ee0bb155fa1619dfd49bca434bf2eee7ad7df9e0 Co-authored-by: Samuel Susla <[email protected]>
shwanton · Mar 10, 2023 · 1a129bc · 1a129bc
1 parent c052800
commit 1a129bc
Showing 1 changed file with 4 additions and 0 deletions.
diff --git a/React/Fabric/Mounting/ComponentViews/ScrollView/RCTScrollViewComponentView.mm b/React/Fabric/Mounting/ComponentViews/ScrollView/RCTScrollViewComponentView.mm
@@ -634,6 +634,10 @@ - (void)scrollToOffset:(CGPoint)offset
 
 - (void)scrollToOffset:(CGPoint)offset animated:(BOOL)animated
 {
+  if (CGPointEqualToPoint(_scrollView.contentOffset, offset)) {
+    return;
+  }
+
   [self _forceDispatchNextScrollEvent];
 
   if (_layoutMetrics.layoutDirection == LayoutDirection::RightToLeft) {