feat: polish CLI after 0.13 updates #750
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chesedo
approved these changes
Mar 26, 2023
Comment on lines
123
to
+129
| let path = serde_json::from_value::<PathBuf>(folder.data.clone()) | ||
| .unwrap() | ||
| .display() | ||
| .to_string(); | ||
| .file_name() | ||
| .expect("static folder path should have a final component") | ||
| .to_str() | ||
| .expect("static folder file name should be valid unicode") | ||
| .to_owned(); |
There was a problem hiding this comment.
Can't we rather get it from folder.config somehow?
There was a problem hiding this comment.
Ah, I didn't think of that! Yes, that should be possible. I likely won't have time to address these today, by the way, but I can get to them in the morning.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
This polishes the resource tables by:
cargo shuttle statusoutput.What I did not do in this PR was remove the
cargo shuttle secretscommand, since I don't want to make this last-minute PR too large. I suggest we do it for the next release.How Has This Been Tested (if applicable)?
Tested locally on this branch: #749, with the
postgrespoem example, but with all resources (database, static, persist, secrets). Here is what it looks like: