Feat: update resources with resourcebuilder changes #747
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oddgrd
force-pushed
the
feat/update-resources
branch
from
bc6f442 to
386183b
Compare
chesedo
approved these changes
Mar 24, 2023
oddgrd
force-pushed
the
feat/update-resources
branch
from
386183b to
ab08311
Compare
oddgrd
commented
Mar 24, 2023
common/src/models/service.rs
Outdated
Comment on lines
241
to
261
| fn get_persist_table(persist_instances: &[&resource::Response]) -> String { | ||
| let mut table = Table::new(); | ||
|
|
||
| table | ||
| .load_preset(UTF8_FULL) | ||
| .apply_modifier(UTF8_ROUND_CORNERS) | ||
| .set_content_arrangement(ContentArrangement::DynamicFullWidth) | ||
| .set_header(vec![ | ||
| Cell::new("Persist Instances").set_alignment(CellAlignment::Center) | ||
| ]); | ||
|
|
||
| for _ in persist_instances { | ||
| table.add_row(vec!["Instance"]); | ||
| } | ||
|
|
||
| format!( | ||
| r#"These instances are linked to this service | ||
| {table} | ||
| "#, | ||
| ) | ||
| } |
There was a problem hiding this comment.
This one I'm not so sure about how we should handle, since the output just contains the project name. 🤔
oddgrd
force-pushed
the
feat/update-resources
branch
from
16d850e to
bc0331d
Compare
chesedo
approved these changes
Mar 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
This updates the resources with the changes in #746, which needs to be merged before this.
How Has This Been Tested (if applicable)?
Local runs.