Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #698

Merged
merged 3 commits into from
Mar 20, 2023
Merged

Update README.md #698

merged 3 commits into from
Mar 20, 2023

Conversation

d2weber
Copy link
Contributor

@d2weber d2weber commented Mar 8, 2023

Description of change

Please write a summary of your changes and why you made them.

Be sure to reference any related issues by adding closes issue #.

How Has This Been Tested (if applicable)?

Please describe the tests that you ran to verify your changes.

Copy link
Contributor

@oddgrd oddgrd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey and thanks for this! I think we can take this one step further and remove the cargo shuttle project status command, project new will no longer return before the project is ready. But, we should also add a comment after cargo shuttle project new since the project might have been created in the init flow above. Something like # if you didn't create your environment on shuttle already.

@d2weber
Copy link
Contributor Author

d2weber commented Mar 10, 2023

Yes I like that idea. I also mentioned that steps should be performed within the project directory as it makes the example more complete.

@d2weber d2weber marked this pull request as ready for review March 10, 2023 15:06
Copy link
Contributor

@oddgrd oddgrd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This is perfect, but I think we should hold off on merging in until we merge #671, since currently if you pass a path that doesn't exist to the init command it will just error.

@oddgrd oddgrd merged commit 89893cd into shuttle-hq:main Mar 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants