Feat/warp support #326
Merged
Feat/warp support #326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… into feat/warp_support
oddgrd
reviewed
Sep 19, 2022
There was a problem hiding this comment.
Hi John, apologies for the delayed review. This looks great though! 🥳 Do you also have time to add a couple of tests? One in e2e/tests/integration and one in cargo-shuttle/tests/integration/run would be terrific. Some people (including CI and I) have trouble running the tests in cargo-shuttle/tests/integration/run currently, but we can merge this anyway if we can verify the test is sound.
|
Sounds good, leave it with me and I'll get them added as soon as I'm back this week. |
|
I think this should now be ok @oddgrd . I don't think the tests fails are related to these changes. |
oddgrd
approved these changes
Oct 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding support for the Warp web server framework with example code and
init --warpfunctionality.