Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: CircleCI migration #277

Merged
merged 36 commits into from
Aug 17, 2022
Merged

Conversation

chesedo
Copy link
Contributor

@chesedo chesedo commented Jul 22, 2022

No description provided.

@chesedo chesedo force-pushed the ci/circleci_migration branch 3 times, most recently from 0b45b30 to facd9d0 Compare July 22, 2022 15:54
@chesedo chesedo force-pushed the ci/circleci_migration branch from facd9d0 to 26e5c7f Compare July 22, 2022 15:55
@chesedo chesedo force-pushed the ci/circleci_migration branch 2 times, most recently from 1042d07 to 7e88364 Compare July 22, 2022 16:33
@chesedo chesedo force-pushed the ci/circleci_migration branch 4 times, most recently from 89b39c1 to fec996a Compare July 22, 2022 16:54
@chesedo chesedo force-pushed the ci/circleci_migration branch from fec996a to 94caf76 Compare July 22, 2022 17:02
@chesedo chesedo force-pushed the ci/circleci_migration branch from 418b37f to d55620c Compare July 22, 2022 18:22
@chesedo chesedo force-pushed the ci/circleci_migration branch 4 times, most recently from ec5102b to ade434c Compare July 23, 2022 08:59
@chesedo chesedo force-pushed the ci/circleci_migration branch from 887467c to 9c8a134 Compare July 25, 2022 10:41
@chesedo chesedo force-pushed the ci/circleci_migration branch from d8db42c to 966fce8 Compare July 25, 2022 14:19
@chesedo chesedo force-pushed the ci/circleci_migration branch from efa175e to 4c284d5 Compare July 26, 2022 06:07
@chesedo chesedo force-pushed the ci/circleci_migration branch from 5ddace2 to 7988c80 Compare July 26, 2022 15:59
@chesedo chesedo force-pushed the ci/circleci_migration branch from c8a86a3 to bba85da Compare July 26, 2022 16:02
@chesedo chesedo requested a review from brokad July 27, 2022 10:50
sudo mkdir -p $BUILDX_CACHE && sudo chown -R circleci:circleci $BUILDX_CACHE
make images
name: Configure buildx cache
command: export BUILDX_CACHE=/tmp/cache/buildx
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm no CircleCI expert, but does this do anything for other steps? I thought each step was ran in a fresh shell.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yip, each step is a fresh shell. Making this a command (line 9) allows me to reuse it for the e2e-test (line 194) and build-and-push (line 224) without needing to repeat (and maintain) it

@chesedo chesedo requested a review from brokad August 16, 2022 09:05
@chesedo chesedo merged commit 6b1a9e5 into shuttle-hq:main Aug 17, 2022
@chesedo chesedo deleted the ci/circleci_migration branch August 17, 2022 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants