-
Notifications
You must be signed in to change notification settings - Fork 254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: v0.49.0 #1917
chore: v0.49.0 #1917
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Summary
Version bump from 0.48.0 to 0.49.0 across the entire Shuttle project, including all workspace packages, examples, and documentation.
- Hides the 'redeploy' command and its alias 're' in the CLI help output in
cargo-shuttle/src/args.rs
- Added package descriptions in
codegen/Cargo.toml
,proto/Cargo.toml
, andruntime/Cargo.toml
- Updated examples submodule from commit 830348b to 65b1195 in
/examples
45 file(s) reviewed, 4 comment(s)
Edit PR Review Bot Settings | Greptile
@@ -7,5 +7,5 @@ edition = "2021" | |||
[workspace] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
logic: workspace declaration without members may cause issues with dependency resolution
@@ -7,5 +7,5 @@ edition = "2021" | |||
[workspace] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
style: Consider removing empty [workspace] section if not needed, as this is a test package
@@ -12,4 +12,4 @@ async-openai = "0.23.0" | |||
async-trait = "0.1.56" | |||
serde = { version = "1.0.203", features = ["derive"] } | |||
serde_json = "1" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
style: serde_json dependency uses unbound version '1' - consider specifying exact version for better reproducibility
@@ -13,7 +13,7 @@ diesel-async = { version = "0.4.1", optional = true } | |||
mongodb = { version = "2.3.0", optional = true } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
style: mongodb version 2.3.0 is outdated, newer versions include important bug fixes and performance improvements
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Summary
(updates since last review)
This PR continues the version 0.49.0 update with changes to project naming and test configurations.
- Renamed test function in
cargo-shuttle/src/config.rs
to reflect new priority of using Cargo.toml package name over Shuttle.toml for project naming - Removed
poem_mongodb
integration test fromcargo-shuttle/tests/integration/run.rs
, suggesting potential deprecation of MongoDB support for Poem framework - Updated test output expectations to align with new project naming conventions
2 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
No description provided.