fix(cargo-shuttle): don't print platform info in unrelated commands #1902
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR modifies the Shuttle command-line tool to prevent printing platform information for specific commands, improving output clarity and relevance.
- Added conditional check in
cargo-shuttle/src/lib.rsto skip platform info printing for Feedback, Generate, and Upgrade commands - Streamlined command output by reducing unnecessary information for non-deployment related operations
- Enhanced user experience by providing more focused and relevant output based on the executed command
1 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile
Comment on lines
+184
to
+187
| if !matches!( | ||
| args.cmd, | ||
| Command::Feedback | Command::Generate(_) | Command::Upgrade { .. } | ||
| ) { |
There was a problem hiding this comment.
style: Consider using a constant or enum for these command types to improve maintainability
oddgrd
approved these changes
Oct 10, 2024
There was a problem hiding this comment.
PR Summary
(updates since last review)
This PR updates the cargo-shuttle package version and modifies command output behavior. Key changes include:
- Incremented
cargo-shuttleversion from 0.48.2 to 0.48.3 incargo-shuttle/Cargo.toml - Updated
CHANGELOG.mdto reflect the version change and new behavior - Modified
cargo-shuttle/src/lib.rsto suppress platform info output for specific commands
1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.