fix(resource-recorder): check project permission by project id #1839
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oddgrd
approved these changes
Jul 25, 2024
| let scope = match Path::<Ulid>::from_request_parts(parts, state).await { | ||
| Ok(Path(ulid)) => { | ||
| let p = service.find_project_by_id(&ulid.to_string()).await?; | ||
| ProjectName::new(&p.name).expect("valid project name") |
There was a problem hiding this comment.
Should we mapp to invalidprojectname err instead?
There was a problem hiding this comment.
Would rather have an internal error than a user facing one here. It should be safe regardless since the name is coming out of the db.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
How has this been tested? (if applicable)
tested on staging