Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cargo-shuttle): beta deploy zip file, package name #1742

Merged
merged 4 commits into from
Apr 17, 2024

Conversation

jonaro00
Copy link
Member

Description of change

How has this been tested? (if applicable)

Copy link
Contributor

@oddgrd oddgrd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just left one question for my own understanding.

Comment on lines +272 to +276
/// Alpha: tar archive. Beta: zip archive.
pub data: Vec<u8>,
/// The cargo package name to compile and run. Required on beta.
pub package_name: Option<String>,
/// Ignored on beta.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding these!

cargo-shuttle/src/lib.rs Show resolved Hide resolved
@jonaro00 jonaro00 merged commit 81ecaae into shuttle-hq:feat/shuttle-ecs-common Apr 17, 2024
24 checks passed
@jonaro00 jonaro00 deleted the deploy-zip-file branch April 17, 2024 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants