feat(cargo-shuttle): beta flag, remove project list pagination logic #1732
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kazy
reviewed
Apr 10, 2024
There was a problem hiding this comment.
Curious how this will scale if we start to have more modification from the current CLI. I was thinking of having two different implementation of the API instead (ShuttleApiClient and ShuttleBetaApiClient basically). This would also make it clearer what isn't implemented vs the other one.
|
Decided to go with a boolean property like this since the amount of differences thus far is very small.
|
Okay, let's keep it that way for now then. |
jonaro00
force-pushed
the
cargo-shuttle-beta
branch
from
8136998 to
a84e586
Compare
iulianbarbu
reviewed
Apr 10, 2024
iulianbarbu
merged commit 72839f0
into
shuttle-hq:feat/shuttle-ecs-common
24 checks passed
iulianbarbu
pushed a commit
that referenced
this pull request
Apr 11, 2024
…1732) * feat(cargo-shuttle): beta flag * nit: client name * fix: delete beta endpoint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #1731