feat: merge runtime updates in main ecs branch #1709
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
running on unspecified ip was necessary for the runner to be able to reach the runtime when they are running in separate containers
iulianbarbu
pushed a commit
that referenced
this pull request
Apr 11, 2024
* feat: runtime healthcheck, start runtime on 0.0.0.0 running on unspecified ip was necessary for the runner to be able to reach the runtime when they are running in separate containers * feat(proto): update runtime::get_client to work with * misc(proto): get client takes u16 port * feat: add health toggle to runtime * feat: set runtime to unhealthy if it doesn't start within 60s * feat: change runtime::get_client to take address * feat: kill runtime if it doesn't become healthy in time * feat: increase provisioning timeout duration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
This adds a healthcheck to the runtime, as well as some logic we can use to ensure the runtime shuts down if it doesn't start the service within a certain timeframe. The logic to make the runtime handle failure well will need some further iteration in the future, since there are a few ways having it as a server that is called by the runner sidecar can lead to failures.
This also changes the runtime to start on the unspecified IP, which is necessary in the new architecture, but the current platform should still use localhost.
How has this been tested? (if applicable)
These changes have been tested on the headroom stack on their own, alongside changes in ecs-shuttle and shuttle-aws.