Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: update services api client #1695

Merged
merged 6 commits into from
Mar 20, 2024
Merged

feat: update services api client #1695

merged 6 commits into from
Mar 20, 2024

Conversation

jonaro00
Copy link
Member

Description of change

  • use reqwest for a simpler api + more convenience

How has this been tested? (if applicable)

chesedo
chesedo reviewed Mar 20, 2024
View reviewed changes
Copy link
Contributor

@chesedo chesedo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just a few small nits

common/Cargo.toml Show resolved Hide resolved
common/src/backends/client/mod.rs Outdated Show resolved Hide resolved
common/src/backends/client/mod.rs Outdated Show resolved Hide resolved
deployer/src/deployment/gateway_client.rs Outdated Show resolved Hide resolved
@jonaro00 jonaro00 merged commit 27c5c37 into shuttle-hq:main Mar 20, 2024
23 of 28 checks passed
@jonaro00 jonaro00 deleted the services-api-client branch March 20, 2024 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chesedo chesedo chesedo left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jonaro00 @chesedo