feat: Add diesel-async support for shuttle-shared-db
#1664
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aumetra
changed the title
diesel-async support for shuttle-shared-dbdiesel-async support for shuttle-shared-db
|
Thanks! Can you add variants for the new feature flags here? Line 158 in b3f3c60 Doing so adds them to CI checks |
jonaro00
approved these changes
Mar 7, 2024
|
Done. Seems like the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
This is the upstreaming of
shuttle-diesel-async, it adds support to outputdiesel-asyncresources from#[shuttle_shared_db::Postgres].Supported resources are:
diesel_async::AsyncPgConnectiondiesel_async::pooled_connection::bb8::Pool(for the above mentionedAsyncPgConnection)diesel_async::pooled_connection::deadpool::Pool(for the above mentionedAsyncPgConnection)How has this been tested? (if applicable)
This is essentially 1:1 the code upstreamed from the repository, the code was used by me in a few projects and has been used by the community as well.