Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deployer): handle cargo fetch without blocking logs, use async channels #1349

Merged
merged 6 commits into from
Nov 2, 2023

Conversation

jonaro00
Copy link
Member

@jonaro00 jonaro00 commented Oct 27, 2023

Description of change

Fixes #1322 and some more

  • Using blocking crossbeam channels was causing logs to be delayed. Switched over to tokio channels everywhere possible.
    • Initial logs from deployment now appear instantly, and one line is printed if the fetching takes time.
  • Do a manual cargo fetch when building, and don't let metadata commands fetch. (this is causing CI fail, will look for compromise.)

How has this been tested? (if applicable)

Local run works as usual, with and without crates cached.
Deployment works for axum hello world with and without --no-test, with and without failing test.

Copy link
Contributor

@oddgrd oddgrd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for getting to the bottom of this! I left some questions.

Copy link
Contributor

@chesedo chesedo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good. Comments are mostly small

@oddgrd oddgrd merged commit 03a8873 into shuttle-hq:main Nov 2, 2023
@jonaro00 jonaro00 deleted the cargo-download-output branch November 2, 2023 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Deployment logs at the start of deployment are delayed
4 participants