Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add detail to postgres/docker AWS RDS setup #115

Merged
merged 2 commits into from
Jun 9, 2023
Merged

Add detail to postgres/docker AWS RDS setup #115

merged 2 commits into from
Jun 9, 2023

Conversation

beyarkay
Copy link
Contributor

I had some trouble getting setup with postgres and docker (I'd never used them before) so this PR contains some postgres-for-dummies style information which would have clarified things for me.

Copy link
Contributor

@oddgrd oddgrd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a couple of minor comments, but this is great, thanks again!

resources/shuttle-aws-rds.mdx Outdated Show resolved Hide resolved
resources/shuttle-aws-rds.mdx Outdated Show resolved Hide resolved
@beyarkay
Copy link
Contributor Author

beyarkay commented Jun 2, 2023

Lemme know what you think! I don't know Maria/MySQL that well but it looks like Maria's a fork of MySQL so they've got the same URI format? At least the only things I could find about Maria's URI format were this SO question (which referred to the MySQL docs) or these MariaDB docs (which didn't actually include URI and told the user to use the mysql binary)

Copy link
Contributor

@oddgrd oddgrd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, I believe they have the same format. This LGTM, thanks!

@oddgrd oddgrd merged commit a895cb3 into shuttle-hq:main Jun 9, 2023
@beyarkay beyarkay deleted the patch-2 branch June 9, 2023 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants