refactor(babel-plugin): work with latest babel #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
|
Took the time to write a proper PR to babel regarding angular2 constructor decorators, but it got closed right away 😭 babel/babel#2138. I'll maintain a fork until pluggable parsers are available. |
|
Thanks for your PR 😄 So, the parameter decorators don't work with the latest babel now. I'll keep this open until some way to solve it become possible. |
|
Merging because the current master doesn't work with the current babel/angular. Thanks! |
shuhei
added a commit
that referenced
this pull request
Aug 31, 2015
refactor(babel-plugin): work with latest babel
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Had to refactor the plugin to work with latest babel. Might be interesting.
I haven't found a way to add parameters annotations back yet. Looks like we're stuck on babel/babel#1351 for now.