[Bug]: `Cannot require() ES Module ~ standalone.mjs in a cycle` when Node >=v22.12.0 with Prettier >= 3.5.0 #311

utqinadhif · 2025-02-17T01:42:23Z

Description

after update from 1.15.2 to 1.15.3, prettier not working with caption Cannot require() ES Module /media/hdd/local/project/php/l11-sim/node_modules/prettier/standalone.mjs in a cycle. (from /media/hdd/local/project/php/l11-sim/node_modules/@prettier/plugin-php/standalone.js)

Expected Behavior

i want to normal again

Actual Behavior

this plugin not work after update

Additional Context

version: 1.15.3
OS: linux debian 12

rishabkapadia · 2025-02-17T16:16:29Z

currently downgraded to get going:
"@shufo/prettier-plugin-blade": "=1.14.1",

npm update @shufo/prettier-plugin-blade

shufo · 2025-02-18T05:25:22Z

Sorry I could not reproduce the error with latest version with prettier 3.5.1

$ node -v
v22.11.0

$ npm list | grep prettier
├── @shufo/prettier-plugin-blade@1.15.3
└── prettier@3.5.1

$ cat package.json
{
  "devDependencies": {
    "@shufo/prettier-plugin-blade": "^1.15.3",
    "prettier": "^3.5.1"
  }
}

$ cat .prettierrc.json
{
  "plugins": ["@shufo/prettier-plugin-blade"],
  "overrides": [
    {
      "files": ["*.blade.php"],
      "options": {
        "parser": "blade",
        "tabWidth": 4
      }
    }
  ]
}

$ ./node_modules/.bin/prettier test.blade.php
@extends('frontend.layouts.app')
@section('title') foo
@endsection
@section('content')
    <section id="content">
        <div class="container mod-users-pd-h">
            <div class="pf-user-header">
                <div></div>
                <p>@lang('users.index')</p>
            </div>
            <div class="pf-users-branch">
                <ul class="pf-users-branch__list">
                    @foreach ($users as $user)
                        <li>
                            <img src="{{ asset('img/frontend/icon/branch-arrow.svg') }}" alt="branch_arrow">
                            {{ link_to_route('frontend.users.user.show', $users['name'], $users['_id']) }}
                        </li>
                    @endforeach
                </ul>
                <div class="pf-users-branch__btn">
                    @can('create', App\Models\User::class)
                        {!! link_to_route('frontend.users.user.create', __('users.create'), [1, 2, 3], ['class' => 'btn']) !!}
                    @endcan
                </div>
            </div>
        </div>
    </section>
@endsection
@section('footer')
@stop

@utqinadhif @rishabkapadia
Can you give how to reproduce the error?

rishabkapadia · 2025-02-18T07:02:14Z

macOS 14.7.2
PHP 8.3.14

node -v
v23.6.1

npm -v
11.1.0

./node_modules/.bin/prettier resources/views/components/guest/nav.blade.php
[error] Cannot require() ES Module ../Sites/webapp/node_modules/prettier/standalone.mjs in a cycle. (from ../Sites/webapp/node_modules/@prettier/plugin-php/standalone.js)

cat .prettierrc
{
  "plugins": ["@shufo/prettier-plugin-blade"],
  "overrides": [
    {
      "files": ["*.blade.php"],
      "options": {
        "parser": "blade",
        "tabWidth": 4
      }
    }
  ]
}

cat package.json | grep prettier
    "@shufo/prettier-plugin-blade": "^1.15.3",
    "prettier": "^3.5.1",

cat package.json
{
  "private": true,
  "scripts": {
    "dev": "vite",
    "build": "vite build",
    "prepare": "husky"    
  },
  "devDependencies": {
    "@shufo/prettier-plugin-blade": "^1.15.3",
    "@tailwindcss/forms": "^0.5.7",
    "alpinejs": "^3.13.3",
    "autoprefixer": "^10.4.16",
    "axios": "^1.6",
    "husky": "^9.0.0",
    "laravel-vite-plugin": "^1.0.1",
    "postcss": "^8.4.33",
    "postcss-import": "^16.0.0",
    "prettier": "^3.5.1",
    "tailwindcss": "^3.4.1",
    "vite": "^6.1.0"
  }
}

also tried:

rm -rf node_modules package-lock.json 
npm install

utqinadhif · 2025-02-18T08:03:25Z

macOS 14.7.2 PHP 8.3.14

node -v
v23.6.1

npm -v
11.1.0

./node_modules/.bin/prettier resources/views/components/guest/nav.blade.php
[error] Cannot require() ES Module ../Sites/webapp/node_modules/prettier/standalone.mjs in a cycle. (from ../Sites/webapp/node_modules/@prettier/plugin-php/standalone.js)

cat .prettierrc
{
  "plugins": ["@shufo/prettier-plugin-blade"],
  "overrides": [
    {
      "files": ["*.blade.php"],
      "options": {
        "parser": "blade",
        "tabWidth": 4
      }
    }
  ]
}

cat package.json | grep prettier
    "@shufo/prettier-plugin-blade": "^1.15.3",
    "prettier": "^3.5.1",

cat package.json
{
  "private": true,
  "scripts": {
    "dev": "vite",
    "build": "vite build",
    "prepare": "husky"    
  },
  "devDependencies": {
    "@shufo/prettier-plugin-blade": "^1.15.3",
    "@tailwindcss/forms": "^0.5.7",
    "alpinejs": "^3.13.3",
    "autoprefixer": "^10.4.16",
    "axios": "^1.6",
    "husky": "^9.0.0",
    "laravel-vite-plugin": "^1.0.1",
    "postcss": "^8.4.33",
    "postcss-import": "^16.0.0",
    "prettier": "^3.5.1",
    "tailwindcss": "^3.4.1",
    "vite": "^6.1.0"
  }
}

also tried:

rm -rf node_modules package-lock.json 
npm install

Thanks

shufo · 2025-02-18T10:11:33Z

Uh I understand, it occurs when combination of node >=v23 with prettier-plugin-blade latest version.

$ node -v
v23.6.1

$ ./node_modules/.bin/prettier test.blade.php
[error] Cannot require() ES Module /home/shuhei/develop/prettier-plugin-blade-test6/node_modules/prettier/standalone.mjs in a cycle. (from /home/shuhei/develop/prettier-plugin-blade-test6/node_modules/@prettier/plugin-php/standalone.js)

Node v22 with latest version was ok.

utqinadhif · 2025-02-18T10:58:52Z

node -v ─╯
v22.14.0

./node_modules/.bin/prettier /media/hdd/local/project/php/l11-sim/resources/views/pdf/display/apm/print/sep.blade.php ─╯
[error] Cannot require() ES Module /media/hdd/local/project/php/l11-sim/node_modules/prettier/standalone.mjs in a cycle. (from /media/hdd/local/project/php/l11-sim/node_modules/@prettier/plugin-php/standalone.js)

In my case, i use v22.14.0 but error,

utqinadhif · 2025-02-18T11:00:46Z

Oh i know, before today, before i update my node, the prettier work well, may be error occurs on >=22.14.0

rishabkapadia · 2025-02-18T11:16:20Z

Uh I understand, it occurs when combination of node >=v23 with prettier-plugin-blade latest version.

$ node -v
v23.6.1

$ ./node_modules/.bin/prettier test.blade.php
[error] Cannot require() ES Module /home/shuhei/develop/prettier-plugin-blade-test6/node_modules/prettier/standalone.mjs in a cycle. (from /home/shuhei/develop/prettier-plugin-blade-test6/node_modules/@prettier/plugin-php/standalone.js)
Node v22 with latest version was ok.

i just tried it with node 22 (& plugin 1.15.3), its not working. i'm on v23 for quite some time (its highly unlikely the cause). faced issues recently (went from 1.13.4 to 1.15.3).

Got it working by downgrading to 1.13.4 with node 23

shufo · 2025-02-18T11:21:16Z

@utqinadhif @rishabkapadia Thanks.

#311 (comment) was not corret.
It seems above node >=v22.12.0 got error.

$ node -v
v22.12.0
$ ./node_modules/.bin/prettier test.blade.php
[error] Cannot require() ES Module /home/shuhei/develop/prettier-plugin-blade-test6/node_modules/prettier/standalone.mjs in a cycle. (from /home/shuhei/develop/prettier-plugin-blade-test6/node_modules/@prettier/plugin-php/standalone.js)

v22.11.0 is ok

$ node -v
v22.11.0

$ ./node_modules/.bin/prettier test.blade.php
@extends('frontend.layouts.app')
@section('title') foo
@endsection
@section('content')
    <section id="content">
        <div class="container mod-users-pd-h">
            <div class="pf-user-header">
                <div></div>
                <p>@lang('users.index')</p>
            </div>
            <div class="pf-users-branch">
                <ul class="pf-users-branch__list">
                    @foreach ($users as $user)
                        <li>
                            <img src="{{ asset('img/frontend/icon/branch-arrow.svg') }}" alt="branch_arrow">
                            {{ link_to_route('frontend.users.user.show', $users['name'], $users['_id']) }}
                        </li>
                    @endforeach
                </ul>
                <div class="pf-users-branch__btn">
                    @can('create', App\Models\User::class)
                        {!! link_to_route('frontend.users.user.create', __('users.create'), [1, 2, 3], ['class' => 'btn']) !!}
                    @endcan
                </div>
            </div>
        </div>
    </section>
@endsection
@section('footer')
@stop

rishabkapadia · 2025-02-18T11:34:27Z

that worked. thank you.

note: if you are using brew, i was not able to install a specific version. instead it kept installing the latest patch (v22.13.1). hence had to install 22.11 via nvm

shufo · 2025-02-18T12:05:07Z

Plus above, Downgrading prettier to 3.4.2 also works on node >=22.12.0 and latest prettier-plugin-blade.

$ node -v
v23.6.1

$ cat package.json
{
  "devDependencies": {
    "@shufo/prettier-plugin-blade": "^1.15.3",
    "prettier": "3.4.2"
  }
}

$ ./node_modules/.bin/prettier test.blade.php
@extends('frontend.layouts.app')
@section('title') foo
@endsection
@section('content')
    <section id="content">
        <div class="container mod-users-pd-h">
            <div class="pf-user-header">
                <div></div>
                <p>@lang('users.index')</p>
            </div>
            <div class="pf-users-branch">
                <ul class="pf-users-branch__list">
                    @foreach ($users as $user)
                        <li>
                            <img src="{{ asset('img/frontend/icon/branch-arrow.svg') }}" alt="branch_arrow">
                            {{ link_to_route('frontend.users.user.show', $users['name'], $users['_id']) }}
                        </li>
                    @endforeach
                </ul>
                <div class="pf-users-branch__btn">
                    @can('create', App\Models\User::class)
                        {!! link_to_route('frontend.users.user.create', __('users.create'), [1, 2, 3], ['class' => 'btn']) !!}
                    @endcan
                </div>
            </div>
        </div>
    </section>
@endsection
@section('footer')
@stop

rishabkapadia · 2025-02-18T12:19:38Z

🙌 after downgrading prettier to 3.4.2, it works on node 22.11.0, 22.12.0, 22.14.0, 23.8.0

shufo · 2025-02-19T09:23:58Z

It seems this prettier's change introduced in 3.5.0 affecting this issue.
https://prettier.io/blog/2025/02/09/3.5.0#use-esm-entrypoint-for-requireesm-16958-by-tats-u

related issue: prettier/plugin-php#2418

utqinadhif · 2025-02-19T10:08:21Z

For now, i use 3.4.2 and wait for new fixing,

fisker · 2025-02-19T17:50:29Z

Hello, I'm from Prettier core team, this should be a Prettier issue, and I'm considering reverting the change mentioned in #311 (comment)

@shufo Can you transfer the issue to Prettier (Not sure if it's possible), so we can continue the discussion there.

Before Prettier fixes this issue, I'll invgate if this is a different case than prettier/prettier#17139

shufo · 2025-02-20T08:31:11Z

@fisker Thank you fisker! Transfering issue requires both repository write access so I added you to this repository's collabolators. You can transfer this issue if you needed.

I don't know what the root cause is now but also I'll investigate it.

fisker · 2025-02-20T10:02:16Z

Added reproduction https://github.com/fisker/prettier-plugin-blade-311, and remove module-sync condition from Prettier fixes the issue as expected.

fisker · 2025-02-20T10:20:10Z

@joyeecheung I just want to let you know that your solution from prettier/prettier#17139 (comment) (replace Promise.all()) won't fix this case. You may want update error message for nodejs/node#57126.

joyeecheung · 2025-02-20T10:35:17Z

I think this may be a different one, the other one is a race when require and dynamic import happens at the same time, and the fix would be making the loading deterministic, which the Node.js is adding a new error message for (replacing "Cannot read properties of undefined"). This one is probably a real cycle, as the existing error message suggests. Either the cycle needs to be broken/made lazy, or there is another suggestion possible, but it is still a different path.

fisker · 2025-02-22T04:22:55Z

Should fixed in Prettier v3.5.2 https://github.com/prettier/prettier/releases/tag/3.5.2

joyeecheung · 2025-02-23T23:09:55Z

FYI I think I figured out what is causing this - fix in nodejs/node#57187 which locally make https://github.com/fisker/prettier-plugin-blade-311 produce

[error] No parser could be inferred for file "/Users/joyee/projects/prettier-plugin-blade-311/fixture.blade.php".

Which is the same as what I see from older Node.js releases without require(esm) e.g. v21

utqinadhif added the bug Something isn't working label Feb 17, 2025

github-actions bot assigned utqinadhif and shufo Feb 17, 2025

shufo changed the title ~~[Bug]: Cannot require() ES Module ~ standalone.mjs in a cycle with Node v23 on latest version~~ [Bug]: Cannot require() ES Module ~ standalone.mjs in a cycle when Node >=v22.12.0 with latest version Feb 18, 2025

shufo changed the title ~~[Bug]: Cannot require() ES Module ~ standalone.mjs in a cycle when Node >=v22.12.0 with latest version~~ [Bug]: Cannot require() ES Module ~ standalone.mjs in a cycle when Node >=v22.12.0 with Prettier >= 3.5.0 Feb 18, 2025

This comment has been minimized.

Sign in to view

fisker mentioned this issue Feb 20, 2025

Revert "Use ESM entrypoint for require(ESM)" prettier/prettier#17156

Merged

joyeecheung mentioned this issue Feb 23, 2025

module: handle cached linked async jobs in require(esm) nodejs/node#57187

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Bug]: `Cannot require() ES Module ~ standalone.mjs in a cycle` when Node >=v22.12.0 with Prettier >= 3.5.0 #311

[Bug]: `Cannot require() ES Module ~ standalone.mjs in a cycle` when Node >=v22.12.0 with Prettier >= 3.5.0 #311

utqinadhif commented Feb 17, 2025

rishabkapadia commented Feb 17, 2025 •

edited

Loading

shufo commented Feb 18, 2025 •

edited

Loading

rishabkapadia commented Feb 18, 2025 •

edited

Loading

utqinadhif commented Feb 18, 2025

shufo commented Feb 18, 2025

utqinadhif commented Feb 18, 2025

utqinadhif commented Feb 18, 2025

rishabkapadia commented Feb 18, 2025 •

edited

Loading

shufo commented Feb 18, 2025

rishabkapadia commented Feb 18, 2025

shufo commented Feb 18, 2025

rishabkapadia commented Feb 18, 2025

shufo commented Feb 19, 2025

utqinadhif commented Feb 19, 2025

fisker commented Feb 19, 2025

shufo commented Feb 20, 2025

This comment has been minimized.

fisker commented Feb 20, 2025

fisker commented Feb 20, 2025 •

edited

Loading

joyeecheung commented Feb 20, 2025 •

edited

Loading

fisker commented Feb 22, 2025

joyeecheung commented Feb 23, 2025

[Bug]: Cannot require() ES Module ~ standalone.mjs in a cycle when Node >=v22.12.0 with Prettier >= 3.5.0 #311

[Bug]: Cannot require() ES Module ~ standalone.mjs in a cycle when Node >=v22.12.0 with Prettier >= 3.5.0 #311

Comments

utqinadhif commented Feb 17, 2025

Description

Expected Behavior

Actual Behavior

Additional Context

rishabkapadia commented Feb 17, 2025 • edited Loading

shufo commented Feb 18, 2025 • edited Loading

rishabkapadia commented Feb 18, 2025 • edited Loading

utqinadhif commented Feb 18, 2025

shufo commented Feb 18, 2025

utqinadhif commented Feb 18, 2025

utqinadhif commented Feb 18, 2025

rishabkapadia commented Feb 18, 2025 • edited Loading

shufo commented Feb 18, 2025

rishabkapadia commented Feb 18, 2025

shufo commented Feb 18, 2025

rishabkapadia commented Feb 18, 2025

shufo commented Feb 19, 2025

utqinadhif commented Feb 19, 2025

fisker commented Feb 19, 2025

shufo commented Feb 20, 2025

This comment has been minimized.

fisker commented Feb 20, 2025

fisker commented Feb 20, 2025 • edited Loading

joyeecheung commented Feb 20, 2025 • edited Loading

fisker commented Feb 22, 2025

joyeecheung commented Feb 23, 2025

[Bug]: `Cannot require() ES Module ~ standalone.mjs in a cycle` when Node >=v22.12.0 with Prettier >= 3.5.0 #311

[Bug]: `Cannot require() ES Module ~ standalone.mjs in a cycle` when Node >=v22.12.0 with Prettier >= 3.5.0 #311

rishabkapadia commented Feb 17, 2025 •

edited

Loading

shufo commented Feb 18, 2025 •

edited

Loading

rishabkapadia commented Feb 18, 2025 •

edited

Loading

rishabkapadia commented Feb 18, 2025 •

edited

Loading

fisker commented Feb 20, 2025 •

edited

Loading

joyeecheung commented Feb 20, 2025 •

edited

Loading