Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Sidebar Issues #315

Closed
wants to merge 2 commits into from
Closed

Fix Sidebar Issues #315

wants to merge 2 commits into from

Conversation

maltejur
Copy link
Contributor

@maltejur maltejur commented Jan 8, 2022

  • Fix: Currently the sidebar isn't hidden on nav pages when the next.js option trailingSlash: true is enabled.
  • Fix: Clicking on a a to an anchor on the same page will lead to the current page being un-highlighted in the sidebar.

Kind of extends #236

@vercel
Copy link

vercel bot commented Jan 8, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

nextra-dev – ./examples/docs

🔍 Inspect: https://vercel.com/shuding/nextra-dev/EQ98121AR4D1hN9iLE1EUwFzfdV8
✅ Preview: Canceled

[Deployment for 0b401f9 canceled]

nextra – ./

🔍 Inspect: https://vercel.com/shuding/nextra/Gk3UKLa3ALNvtCzn2EGcbEGgCbAy
✅ Preview: Canceled

[Deployment for 0b401f9 canceled]

@vercel vercel bot temporarily deployed to Preview – nextra-dev January 8, 2022 20:52 Inactive
@vercel vercel bot temporarily deployed to Preview – nextra January 8, 2022 20:52 Inactive
@vercel vercel bot temporarily deployed to Preview – nextra January 14, 2022 22:11 Inactive
@vercel vercel bot temporarily deployed to Preview – nextra-dev January 14, 2022 22:11 Inactive
@maltejur maltejur changed the title Fix sidebar not hidden on nav pages when trailingSlash: true Fix Sidebar Issues Jan 14, 2022
@TheMikeyRoss
Copy link

Any update on this one?

@dimaMachina
Copy link
Collaborator

closing due time, I guess this issue was already fixed in v3, feel free to create an issue if you still need help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants